Skip to content

A minor flurry of selftest/mm fixes

John Hubbard linux-doc linux-kselftest linux-mm live-patching lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 posting 2/210 of 11 patches 3 repliesIn review
  2. v3 Latest11 patches 27 repliesIn review 10 of 11 applied
  3. v2 posting 1/211 patches 16 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v112 patches41 repliesSuperseded

Patches in v3 10 of 11 applied

#Subject and filesSizeRepliesApplied
1/11selftests/mm: fix uffd-stress unused function warningtools/testing/selftests/mm/uffd-stress.c+0 -101 replyApplied
2/11selftests/mm: fix unused variable warnings in hugetlb-madvise.c, migration.ctools/testing/selftests/mm/hugetlb-madvise.c tools/testing/selftests/mm/migration.c+10 -31 replyApplied
3/11selftests/mm: fix "warning: expression which evaluates to zero..." in mlock2-tests.ctools/testing/selftests/mm/mlock2-tests.c+0 -11 replyApplied
4/11selftests/mm: fix invocation of tests that are run via shell scriptstools/testing/selftests/mm/run_vmtests.sh+3 -31 replyApplied
5/11selftests/mm: .gitignore: add mkdirty, va_high_addr_switchtools/testing/selftests/mm/.gitignore+2 -01 replyApplied
6/11selftests/mm: fix two -Wformat-security warnings in uffd buildstools/testing/selftests/mm/uffd-unit-tests.c+6 -101 replyApplied
7/11selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.htools/testing/selftests/mm/pkey-x86.h+1 -11 replyApplied
8/11selftests/mm: fix build failures due to missing MADV_COLLAPSEtools/testing/selftests/mm/cow.c tools/testing/selftests/mm/khugepaged.c tools/testing/selftests/mm/vm_util.h+10 -171 replyApplied
9/11selftests/mm: move certain uffd*() routines from vm_util.c to uffd-common.ctools/testing/selftests/mm/uffd-common.c tools/testing/selftests/mm/uffd-common.h tools/testing/selftests/mm/vm_util.c +1 more+64 -631 replyApplied
10/11Documentation: kselftest: "make headers" is a prerequisiteDocumentation/dev-tools/kselftest.rst+1 -02 repliesApplied
11/11selftests: error out if kernel header files are not yet builttools/testing/selftests/lib.mk+33 -316 replies

Reviews trailers per patch

All 11 patches have a Reviewed-by or Acked-by.

PatchDavid HildenbrandPeter XuMuhammad Usama Anjum
1/11R-b R-b T-b
2/11R-b R-b T-b
3/11R-b R-b T-b
4/11A-b T-b
5/11R-b R-b T-b
6/11R-b R-b T-b
7/11R-b T-b
8/11R-b T-b
9/11A-b T-b
10/11R-b R-b
11/11R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 00/11] A minor flurry of selftest/mm fixes

Hi,

Changes since v2 [1]:

* Added a new patch (sent separately earlier) at the end, to error out if "make headers" has not yet been run.

* Reworked and simplified the uffd movement patch. Now it only moves some uffd*() routines, not all, and doesn't have to touch the Makefile at all. This lighter touch also allowed me to drop the "move psize(), pshift() into vm_utils.c" entirely. I expect Peter Xu will be a little happier with this new approach.

* Fixed the commit description for the MADV_COLLAPSE patch.

* Added more Reviewed-by tags from David Hildenbrand and Peter Xu.

[1] https://lore.kernel.org/all/[email protected]/

John Hubbard (11):
selftests/mm: fix uffd-stress unused function warning selftests/mm: fix unused variable warnings in hugetlb-madvise.c,
migration.c
selftests/mm: fix "warning: expression which evaluates to zero..." in
mlock2-tests.c
selftests/mm: fix invocation of tests that are run via shell scripts selftests/mm: .gitignore: add mkdirty, va_high_addr_switch selftests/mm: fix two -Wformat-security warnings in uffd builds selftests/mm: fix a "possibly uninitialized" warning in pkey-x86.h selftests/mm: fix build failures due to missing MADV_COLLAPSE selftests/mm: move certain uffd*() routines from vm_util.c to
uffd-common.c
Documentation: kselftest: "make headers" is a prerequisite
selftests: error out if kernel header files are not yet built

 Documentation/dev-tools/kselftest.rst        |  1 +
 tools/testing/selftests/lib.mk               | 36 +++++++++++-
 tools/testing/selftests/mm/.gitignore        |  2 +
 tools/testing/selftests/mm/cow.c             |  7 ---
 tools/testing/selftests/mm/hugetlb-madvise.c |  8 ++-
 tools/testing/selftests/mm/khugepaged.c      | 10 ----
 tools/testing/selftests/mm/migration.c       |  5 +-
 tools/testing/selftests/mm/mlock2-tests.c    |  1 -
 tools/testing/selftests/mm/pkey-x86.h        |  2 +-
 tools/testing/selftests/mm/run_vmtests.sh    |  6 +-
 tools/testing/selftests/mm/uffd-common.c     | 59 ++++++++++++++++++++
 tools/testing/selftests/mm/uffd-common.h     |  5 ++
 tools/testing/selftests/mm/uffd-stress.c     | 10 ----
 tools/testing/selftests/mm/uffd-unit-tests.c | 16 ++----
 tools/testing/selftests/mm/vm_util.c         | 59 --------------------
 tools/testing/selftests/mm/vm_util.h         | 14 +++--
 16 files changed, 130 insertions(+), 111 deletions(-)

base-commit: f8dba31b0a826e691949cd4fdfa5c30defaac8c5

Signature · 1 line
2.40.1