migration: switchover-hold flag
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest2 patches 5 repliesIn review
- v42 patches 2 repliesSuperseded
- v32 patches 1 replySuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 0 replies | Superseded | |
| v1 | 2 patches | 4 replies | Superseded |
Changes in v5 from the cover letter
- Fix HMP set the new bit [Avihai]
Patches in v5 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | migration: switchover-hold parametermigration/ migration/ migration/ +2 more | +128 | 5 replies | |
| 2/2 | qtest/migration: Use switchover-hold to speeduptests/ | +29 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.
Cover letter [PATCH v5 0/2] migration: switchover-hold flag
This v5 patchset is based on master. Since I'm not sure how long this series will take for review, we could probably apply Dan's previous patch 10 first, then when I repost I can provide a revert patch when needed.
v5:
- Fix HMP set the new bit [Avihai]
A new flag "switchover-hold" is added to allow src qemu explicitly hold switchover for precopy migration. Note that this flag will not affect postcopy switchover because src qemu already has migrate-start-postcopy, which is a finer grained knob just for that. In general this flag only affects reaching migration completion phase, when set it'll block it from happening while keep the migration iteration going.
This can be used in two cases so far in my mind:
(1) One can use this parameter to start pre-heating migration (but not really migrating, so a migrate-cancel will cancel the preheat). When the user wants to really migrate, just clear the flag. It'll in most cases migrate immediately because most pages are already synced.
(2) Can also be used as a clean way to do qtest, in many of the precopy tests we have requirement to run after 1 iteration without completing the precopy migration. Before that we have either set bandwidth to ridiculous low value, or tricks on detecting guest memory change over some adhoc guest memory position. Now we can simply set this flag then we know precopy won't complete and will just keep going.
The 1st use case may look a bit like COLO where we can actually keep both QEMU _mostly_ in sync. I'm not sure whether it can be useful anywhere, though.
Patch 1 will introduce the new flag.
Patch 2 will leverage the new flag to speed up migration-test. An initial test is this can make migration-test finish within a little bit less than 1m.
Please have a look, thanks.
Peter Xu (2):
migration: switchover-hold parameter
qtest/migration: Use switchover-hold to speedup
qapi/migration.json | 25 ++++++++++-- migration/migration.h | 17 +++++++++ migration/migration-hmp-cmds.c | 7 ++++ migration/migration.c | 69 ++++++++++++++++++++++++++++++++-- migration/options.c | 17 +++++++++ tests/qtest/migration-test.c | 39 ++++++++++++++----- 6 files changed, 157 insertions(+), 17 deletions(-)
Signature · 1 line
2.41.0