Skip to content

rfs: annotate lockless accesses

Eric Dumazet netdev 2 versions – Applied

Status from this message: This series was applied to netdev/net.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 4 repliesApplied 2/2
  2. v12 patches 6 repliesSuperseded

Patches in v2 All 2 applied

#Subject and filesSizeRepliesApplied
1/2rfs: annotate lockless accesses to sk->sk_rxhashinclude/net/sock.h+13 -52 repliesApplied
2/2rfs: annotate lockless accesses to RFS sock flow tableinclude/linux/netdevice.h net/core/dev.c+9 -42 repliesApplied

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchSimon HormanKuniyuki Iwashima
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 net 0/2] rfs: annotate lockless accesses

rfs runs without locks held, so we should annotate read and writes to shared variables.

It should prevent compilers forcing writes
in the following situation:

  if (var != val)
     var = val;

A compiler could indeed simply avoid the conditional:

    var = val;

This matters if var is shared between many cpus.

v2: aligns one closing bracket (Simon)
adds Fixes: tags (Jakub)

Eric Dumazet (2):
rfs: annotate lockless accesses to sk->sk_rxhash
rfs: annotate lockless accesses to RFS sock flow table

 include/linux/netdevice.h |  7 +++++--
 include/net/sock.h        | 18 +++++++++++++-----
 net/core/dev.c            |  6 ++++--
 3 files changed, 22 insertions(+), 9 deletions(-)
Signature · 1 line
2.41.0.rc0.172.g3f132b7071-goog