Skip to content

scsi: fixes for targets with many LUNs, and scsi_target_block rework

[email protected] linux-block linux-scsi 7 versions – Applied

Status from this message: Applied to 6.5/scsi-staging, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest7 patches 2 repliesApplied
  2. v67 patches 0 repliesSuperseded
  3. v57 patches 12 repliesSuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v46 patches4 repliesSuperseded
v38 patches12 repliesSuperseded
v23 patches13 repliesSuperseded
v13 patches3 repliesSuperseded

Changes in v7 from the cover letter

- 6/7: fixed mistake I made inverting the argument order in v6 (I apologize for overlooking this dumb mistake!!)

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/7bsg: increase number of devicesblock/bsg.c+1 -10 replies
2/7scsi: sg: increase number of devicesdrivers/scsi/sg.c+1 -10 replies
3/7scsi: merge scsi_internal_device_block() and device_block()drivers/scsi/scsi_lib.c+8 -190 replies
4/7scsi: don't wait for quiesce in scsi_stop_queue()drivers/scsi/scsi_lib.c+16 -160 replies
5/7scsi: don't wait for quiesce in scsi_device_block()drivers/scsi/scsi_lib.c+10 -70 replies
6/7scsi: replace scsi_target_block() by scsi_block_targets()drivers/scsi/scsi_lib.c drivers/scsi/scsi_transport_fc.c drivers/scsi/scsi_transport_iscsi.c +3 more+24 -170 replies
7/7scsi: improve warning message in scsi_device_block()drivers/scsi/scsi_lib.c+4 -20 replies

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchChristoph HellwigMing LeiBart Van AsscheHannes ReineckeDouglas Gilbert
1/7R-b R-b R-b
2/7R-b R-b R-b A-b
3/7R-b R-b
4/7R-b R-b
5/7R-b R-b R-b
6/7R-b R-b R-b
7/7R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v7 thread

Cover letter [PATCH v7 0/7] scsi: fixes for targets with many LUNs, and scsi_target_block rework

From: Martin Wilck <[email protected]>

This patch series addresses some issues we saw in a test setup with a large number of SCSI LUNs. The first two patches simply increase the number of available sg and bsg devices. 3-5 fix
a large delay we encountered between blocking a Fibre Channel remote port and the dev_loss_tmo. 6 renames scsi_target_block() to scsi_block_targets(), and makes additional changes to this API, as suggested in the review of the v2 series. 7 improves a warning message.

Changes v6 -> v7
- 6/7: fixed mistake I made inverting the argument order in v6 (I apologize for overlooking this dumb mistake!!)

Changes v5 -> v6
- 6/7: inverted order of arguments for scsi_block_targets (Christoph Hellwig), dropped "extern" (I took the liberty not to remove previous "Reviewed-by"'s because of this change)
- 5/7: wrapped one over-long comment line
- added tags

Changes v4 -> v5:
- added 7/7 to improve the WARN_ON_ONCE in scsi_device_block() (Bart van Assche)
- 6/7: added WARN_ON_ONCE in scsi_block_targets() (Bart van Assche)
- 4/7: improved comment (Bart van Assche)
- Added tags

Changes v3 -> v4:
- skipped 4/8: keep state_mutex held while quiescing queue (Bart van Assche), added a comment in 4/6 to explain the rationale
- renamed scsi_target_block() to scsi_block_targets() (Christoph Hellwig), and merged the previous patches 7/8 and 8/8 modifying this API into 6/6.
- rebased to latest mkp/queue branch

Changes v2 -> v3:
- Split previous 3/3 into 4 separate patches as suggested by Christoph Hellwig.
- Added 7/8 and 8/8, as suggested by Christoph and Bart van Assche.
- Added s-o-b and reviewed-by tags.

Changes v1 -> v2:
- call blk_mq_wait_quiesce_done() from scsi_target_block() to cover the case where BLK_MQ_F_BLOCKING is set (Bart van Assche)

Hannes Reinecke (2):
bsg: increase number of devices
scsi: sg: increase number of devices

Martin Wilck (5):
scsi: merge scsi_internal_device_block() and device_block()
scsi: don't wait for quiesce in scsi_stop_queue()
scsi: don't wait for quiesce in scsi_device_block()
scsi: replace scsi_target_block() by scsi_block_targets()
scsi: improve warning message in scsi_device_block()

 block/bsg.c                         |  2 +-
 drivers/scsi/scsi_lib.c             | 80 ++++++++++++++---------------
 drivers/scsi/scsi_transport_fc.c    |  2 +-
 drivers/scsi/scsi_transport_iscsi.c |  3 +-
 drivers/scsi/scsi_transport_srp.c   |  6 +--
 drivers/scsi/sg.c                   |  2 +-
 drivers/scsi/snic/snic_disc.c       |  2 +-
 include/scsi/scsi_device.h          |  2 +-
 8 files changed, 50 insertions(+), 49 deletions(-)
Signature · 1 line
2.40.1