ppc/pnv: Add chiptod and core timebase state machine models
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 13 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | pnv/chiptod: Add POWER9/10 chiptod modelhw/ hw/ hw/ +7 more | +618 | 3 replies | |
| 2/4 | target/ppc: Tidy POWER book4 SPR registrationtarget/ | +60 | 1 reply | |
| 3/4 | target/ppc: add TFMR SPR implementation with read and write helperstarget/ target/ target/ +2 more | +28 | 1 reply | |
| 4/4 | target/ppc: Implement core timebase state machine and TFMRtarget/ target/ | +179 | 1 reply |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Cédric Le Goater |
|---|---|
| 1/4 | |
| 2/4 | R-b |
| 3/4 | R-b |
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/4] ppc/pnv: Add chiptod and core timebase state machine models
This adds support for chiptod and core timebase state machine models in the powernv POWER9 and POWER10 models.
This does not actually change the time or the value in TB registers (because they are alrady synced in QEMU), but it does go through the motions. It is enough to be able to run skiboot's chiptod initialisation code that synchronises core timebases (after a patch to prevent skiboot skipping chiptod for QEMU, posted to skiboot mailing list).
Sorry there was some delay since the last posting. There is a bit more interest in this recently but feedback and comments from RFC was not forgotten and is much appreciated.
https://lists.gnu.org/archive/html/qemu-ppc/2022-08/msg00324.html
I think I accounted for everything except moving register defines to the .h file. I'm on the fence about that but if they are only used in the .c file I think it's okay to keep them there for now. I cut out a lot of unused ones so it's not so cluttered now.
Lots of other changes and fixes since that RFC. Notably:
- Register names changed to match the workbook names instead of skiboot.
- TFMR moved to timebase_helper.c from misc_helper.c
- More comprehensive model and error checking, particularly of TFMR.
- POWER10 with multi-chip support.
- chiptod and core timebase linked via specific state instead of TFMR.
There is still a vast amount that is not modeled, but most of it related to error handling, injection, failover, etc that is very complicated and not required for normal operation.
Thanks,
Nick
Nicholas Piggin (4):
pnv/chiptod: Add POWER9/10 chiptod model
target/ppc: Tidy POWER book4 SPR registration target/ppc: add TFMR SPR implementation with read and write helpers target/ppc: Implement core timebase state machine and TFMR
hw/ppc/meson.build | 1 + hw/ppc/pnv.c | 38 +++ hw/ppc/pnv_chiptod.c | 488 +++++++++++++++++++++++++++++++++++ hw/ppc/pnv_xscom.c | 2 + hw/ppc/trace-events | 4 + include/hw/ppc/pnv_chip.h | 3 + include/hw/ppc/pnv_chiptod.h | 64 +++++ include/hw/ppc/pnv_core.h | 3 + include/hw/ppc/pnv_xscom.h | 9 + target/ppc/cpu.h | 40 +++ target/ppc/cpu_init.c | 92 ++++--- target/ppc/helper.h | 2 + target/ppc/spr_common.h | 2 + target/ppc/timebase_helper.c | 156 +++++++++++ target/ppc/translate.c | 10 + 15 files changed, 882 insertions(+), 32 deletions(-) create mode 100644 hw/ppc/pnv_chiptod.c create mode 100644 include/hw/ppc/pnv_chiptod.h
Signature · 1 line
2.40.1