Skip to content

Cleanups and improvements

Damien Le Moal linux-ide linux-scsi 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 6 repliesIn review
  2. v13 patches 13 repliesSuperseded

Changes in v2 from the cover letter

- Improved comments in the code changes introduced in patch 1
- Fixed typos in the commit message of patch 2 and 3
- Added Review tags from Hannes and John

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ata: libata-sata: Improve ata_change_queue_depth()drivers/ata/libata-sata.c+21 -101 reply
2/3ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down()drivers/ata/libata-eh.c+1 -32 replies
3/3ata: libata-scsi: Use ata_ncq_supported in ata_scsi_dev_config()drivers/ata/libata-scsi.c+1 -13 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchHannes ReineckeJohn GarryJohannes Thumshirn
1/3R-b R-b R-b
2/3R-b R-b R-b
3/3R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/3] Cleanups and improvements

Improve ata_change_queue_depth() to have its behavior with libsas managed devices consistent with libata managed devices. Also add a couple of simple cleanups to use defined helper functions instead of open coding device flags checks.

Changes from v1:
- Improved comments in the code changes introduced in patch 1
- Fixed typos in the commit message of patch 2 and 3
- Added Review tags from Hannes and John

Damien Le Moal (3):
ata: libata-sata: Improve ata_change_queue_depth()
ata: libata-eh: Use ata_ncq_enabled() in ata_eh_speed_down()
ata: libata-scsi: Use ata_ncq_supported in ata_scsi_dev_config()

 drivers/ata/libata-eh.c   |  4 +---
 drivers/ata/libata-sata.c | 31 +++++++++++++++++++++----------
 drivers/ata/libata-scsi.c |  2 +-
 3 files changed, 23 insertions(+), 14 deletions(-)
Signature · 1 line
2.40.1