Skip to content

Improve ioprio tests

Damien Le Moal ltp 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2ioprio: use ioprio.h kernel header if it existsconfigure.ac testcases/kernel/syscalls/ioprio/ioprio.h+23 -71 reply
2/2ioprio: Use IOPRIO_PRIO_NUM to check prio rangetestcases/kernel/syscalls/ioprio/ioprio.h testcases/kernel/syscalls/ioprio/ioprio_set03.c+3 -33 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchLinus Walleij
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [LTP] [PATCH 0/2] Improve ioprio tests

The ioprio syscall tests rely on ltp internal definitions of the IOPRIO_XXX() macro defining priority classes and levels. With changes to the ioprio API to support command duration limits, these internal definitions are incomplete, causing test case ioprio_set03 to fail.

Avoid this issue by having the iprio tests use the kernel header file definitions if that header exists. This enables additional checks in the header file [1] which restores the expected results with test ioprio_set03.

[1] https://lore.kernel.org/linux-block/[email protected]/

Note: a review of this patch on the kernel block mailing list would be very appreciated.

Damien Le Moal (2):
ioprio: use ioprio.h kernel header if it exists
ioprio: Use IOPRIO_PRIO_NUM to check prio range

 configure.ac                                  |  1 +
 testcases/kernel/syscalls/ioprio/ioprio.h     | 33 ++++++++++++++-----
 .../kernel/syscalls/ioprio/ioprio_set03.c     |  2 +-
 3 files changed, 26 insertions(+), 10 deletions(-)
Signature · 5 lines
2.40.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp