Skip to content

Implement support for SRIOV + LAG

Dave Ertman intel-wired-lan netdev 6 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest10 patches 12 repliesIn review
  2. v5 posting 2/210 patches 0 repliesSuperseded
  3. v5 posting 1/210 patches 4 repliesSuperseded
Earlier versions · 3
VersionPostedPatchesRepliesStatus
v410 patches15 repliesSuperseded
v310 patches10 repliesSuperseded
v210 patches20 repliesSuperseded

Changes in v6 from the cover letter

use PF from lag stuct in function
remove extra blank line

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ice: Correctly initialize queue context valuesdrivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_sched.c+19 -51 reply
2/10ice: Add driver support for firmware changes for LAGdrivers/net/ethernet/intel/ice/ice.h drivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c +5 more+66 -301 reply
3/10ice: changes to the interface with the HW and FW for SRIOV_VF+LAGdrivers/net/ethernet/intel/ice/ice_adminq_cmd.h drivers/net/ethernet/intel/ice/ice_common.c drivers/net/ethernet/intel/ice/ice_common.h +4 more+211 -291 reply
4/10ice: implement lag netdev event handlerdrivers/net/ethernet/intel/ice/ice_lag.c drivers/net/ethernet/intel/ice/ice_lag.h+140 -141 reply
5/10ice: process events created by lag netdev event handlerdrivers/net/ethernet/intel/ice/ice_lag.c drivers/net/ethernet/intel/ice/ice_lag.h drivers/net/ethernet/intel/ice/ice_switch.c +2 more+501 -741 reply
6/10ice: Flesh out implementation of support for SRIOV on bonded interfacedrivers/net/ethernet/intel/ice/ice_lag.c+812 -101 reply
7/10ice: support non-standard teardown of bond interfacedrivers/net/ethernet/intel/ice/ice_lag.c+40 -71 reply
8/10ice: enforce interface eligibility and add messaging for SRIOV LAGdrivers/net/ethernet/intel/ice/ice_lag.c+84 -51 reply
9/10ice: enforce no DCB config changing when in bonddrivers/net/ethernet/intel/ice/ice_dcb_nl.c+50 -01 reply
10/10ice: update reset path for SRIOV LAG supportdrivers/net/ethernet/intel/ice/ice_lag.c drivers/net/ethernet/intel/ice/ice_lag.h drivers/net/ethernet/intel/ice/ice_main.c+244 -41 reply

Reviews trailers per patch

9 of 10 patches have a Reviewed-by or Acked-by.

PatchSimon HormanDaniel MachonSujai Buvaneswaran
1/10R-b R-b T-b
2/10R-b T-b
3/10R-b T-b
4/10T-b
5/10R-b T-b
6/10R-b T-b
7/10R-b T-b
8/10R-b T-b
9/10R-b T-b
10/10R-b T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v6 thread

Cover letter [PATCH iwl-next v6 00/10] Implement support for SRIOV + LAG

Implement support for SRIOV VF's on interfaces that are in an aggregate interface.

The first interface added into the aggregate will be flagged as the primary interface, and this primary interface will be responsible for managing the VF's resources. VF's created on the primary are the only VFs that will be supported on the aggregate. Only Active-Backup mode will be supported and only aggregates whose primary interface is in switchdev mode will be supported.

Additional restrictions on what interfaces can be added to the aggregate and still support SRIOV VFs are:
- interfaces have to all be on the same physical NIC
- all interfaces have to have the same QoS settings
- interfaces have to have the FW LLDP agent disabled
- only the primary interface is to be put into switchdev mode
- no more than two interfaces in the aggregate

Changes since v1:
Fix typo in commit message
Fix typos in warning messages
Fix typo in function header
Use correct bitwise operator instead of boolean

Changes since v2:
Rebase on current next-queue
Fix typos in commits
Fix typos in function headers
use %u for unsigned values in debug message
Refactor common code in node moves to subfunction

Changes since v3:
Fix typos in warning messages
move refactor of common code to earlier patch expand use of refactored code
move prototype and func call into patch that defines func

Changes since v4:
Change module_init to use goto unwind approach Change function name to be more descriptive
chagen variable to be more scope specific
Make sure non-feature specific functions are still performed Free correct memory
Fix typos in warning messages
added check for invalid TEID in queue cfg

Changes since v5:
use PF from lag stuct in function
remove extra blank line

Dave Ertman (9):
ice: Add driver support for firmware changes for LAG
ice: changes to the interface with the HW and FW for SRIOV_VF+LAG
ice: implement lag netdev event handler
ice: process events created by lag netdev event handler
ice: Flesh out implementation of support for SRIOV on bonded interface
ice: support non-standard teardown of bond interface
ice: enforce interface eligibility and add messaging for SRIOV LAG
ice: enforce no DCB config changing when in bond
ice: update reset path for SRIOV LAG support

Jacob Keller (1):
ice: Correctly initialize queue context values

 drivers/net/ethernet/intel/ice/ice.h          |    5 +
 .../net/ethernet/intel/ice/ice_adminq_cmd.h   |   53 +-
 drivers/net/ethernet/intel/ice/ice_common.c   |   56 +
 drivers/net/ethernet/intel/ice/ice_common.h   |    4 +
 drivers/net/ethernet/intel/ice/ice_dcb_nl.c   |   50 +
 drivers/net/ethernet/intel/ice/ice_lag.c      | 1839 ++++++++++++++++-
 drivers/net/ethernet/intel/ice/ice_lag.h      |   34 +-
 drivers/net/ethernet/intel/ice/ice_lib.c      |    2 +-
 drivers/net/ethernet/intel/ice/ice_lib.h      |    1 +
 drivers/net/ethernet/intel/ice/ice_main.c     |   36 +-
 drivers/net/ethernet/intel/ice/ice_sched.c    |   37 +-
 drivers/net/ethernet/intel/ice/ice_sched.h    |   21 +
 drivers/net/ethernet/intel/ice/ice_switch.c   |   88 +-
 drivers/net/ethernet/intel/ice/ice_switch.h   |   29 +
 drivers/net/ethernet/intel/ice/ice_type.h     |    2 +
 drivers/net/ethernet/intel/ice/ice_virtchnl.c |    2 +
 16 files changed, 2124 insertions(+), 135 deletions(-)
Signature · 1 line
2.40.1