Skip to content

posix-timers: Cure the SIG_IGN mess

Thomas Gleixner lkml 7 versions – Applied

Status from this message: The following commit has been merged into the timers/core branch of tip:

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest21 patches 7 repliesApplied
  2. v620 patches 21 repliesSuperseded
  3. v526 patches 45 repliesApplied
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v427 patches8 repliesSuperseded
v351 patches17 repliesSuperseded
v250 patches36 repliesSuperseded
v145 patches20 repliesSuperseded

Changes in v7 from the cover letter

- Update timer state consistently in posix_cpu_timer_del() - Frederic

- Cured the timer delete/exit issue vs. SIG_IGN - Frederic

- Use the proper list head in the exit path - Frederic

- Picked up Reviewed-by tags as appropriate

Patches in v7 Applied

#Subject and filesSizeRepliesApplied
1/21posix-cpu-timers: Correctly update timer status in posix_cpu_timer_del()kernel/time/posix-cpu-timers.c+6 -61 reply
2/21posix-timers: Make signal delivery consistentinclude/linux/posix-timers.h kernel/signal.c kernel/time/posix-cpu-timers.c +1 more+19 -190 replies
3/21posix-timers: Make signal overrun accounting sensiblekernel/signal.c kernel/time/posix-timers.c+6 -110 replies
4/21posix-cpu-timers: Cleanup the firing logicinclude/linux/posix-timers.h kernel/time/posix-cpu-timers.c+25 -110 replies
5/21posix-cpu-timers: Use dedicated flag for CPU timer nanosleepinclude/linux/posix-timers.h kernel/time/posix-cpu-timers.c+4 -10 replies
6/21posix-timers: Add a refcount to struct k_itimerinclude/linux/posix-timers.h kernel/time/posix-timers.c+18 -30 replies
7/21signal: Split up __sigqueue_alloc()kernel/signal.c+35 -170 replies
8/21signal: Provide posixtimer_sigqueue_init()include/linux/posix-timers.h kernel/signal.c+13 -00 replies
9/21posix-timers: Store PID type in the timerinclude/linux/posix-timers.h kernel/time/posix-timers.c+8 -30 replies
10/21signal: Refactor send_sigqueue()include/linux/posix-timers.h include/linux/sched/signal.h kernel/signal.c +1 more+47 -390 replies
11/21signal: Replace resched_timer logicinclude/linux/posix-timers.h kernel/signal.c kernel/time/posix-timers.c+24 -151 reply
12/21posix-timers: Embed sigqueue in struct k_itimerfs/proc/base.c include/linux/posix-timers.h kernel/signal.c +1 more+87 -470 replies
13/21signal: Cleanup unused posix-timer leftoversinclude/linux/sched/signal.h kernel/signal.c+4 -370 replies
14/21posix-timers: Move sequence logic into struct k_itimerinclude/linux/posix-timers.h include/uapi/asm-generic/siginfo.h kernel/signal.c +1 more+7 -100 replies
15/21signal: Provide ignored_posix_timers listinclude/linux/sched/signal.h init/init_task.c kernel/fork.c+5 -20 replies
16/21posix-timers: Handle ignored list on delete and exitinclude/linux/posix-timers.h kernel/time/posix-timers.c+31 -11 reply
17/21signal: Handle ignored signals in do_sigaction(action != SIG_IGN)kernel/signal.c+52 -10 replies
18/21signal: Queue ignored posixtimers on ignore listinclude/linux/posix-timers.h kernel/signal.c kernel/time/posix-timers.c+83 -61 reply
19/21posix-timers: Cleanup SIG_IGN workaround leftoversinclude/linux/posix-timers.h kernel/signal.c kernel/time/alarmtimer.c +3 more+24 -1251 reply
20/21alarmtimers: Remove the throttle mechanism from alarm_forward_now()kernel/time/alarmtimer.c+2 -261 reply
21/21alarmtimers: Remove return value from alarm functionsdrivers/power/supply/charger-manager.c fs/timerfd.c include/linux/alarmtimer.h +2 more+10 -271 reply

Reviews trailers per patch

All 21 patches have a Reviewed-by or Acked-by.

PatchFrederic WeisbeckerPeter Zijlstra (Intel)Eric W. Biederman
1/21R-b
2/21R-b
3/21R-b A-b
4/21R-b
5/21R-b A-b
6/21R-b A-b
7/21R-b A-b
8/21R-b A-b
9/21R-b A-b
10/21R-b A-b
11/21R-b A-b
12/21R-b A-b
13/21R-b A-b
14/21R-b A-b
15/21R-b A-b
16/21R-b A-b
17/21R-b A-b
18/21R-b A-b
19/21R-b A-b
20/21R-b A-b
21/21A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v7 thread

Cover letter [patch V7 00/21] posix-timers: Cure the SIG_IGN mess

This are the remaining bits to cure the SIG_IGN mess. Version 5 can be found here:

https://lore.kernel.org/lkml/[email protected]

Last year I reread a 15 years old comment about the SIG_IGN problem:

"FIXME: What we really want, is to stop this timer completely and restart
it in case the SIG_IGN is removed. This is a non trivial change which involves sighand locking (sigh !), which we don't want to do late in the release cycle. ... A more complex fix which solves also another related inconsistency is already in the pipeline."

The embarrasing part was that I put that comment in back then. So I went back and rumaged through old notes as I completely had forgotten why our attempts to fix this back then failed.

It turned out that the comment is about right: sighand locking and life time issues. So I sat down with the old notes and started to wrap my head around this again.

The problem to solve:

Posix interval timers are not rearmed automatically by the kernel for various reasons:

1) To prevent DoS by extremly short intervals.
2) To avoid timer overhead when a signal is pending and has not yet been delivered.

This is achieved by queueing the signal at timer expiry and rearming the timer at signal delivery to user space. This puts the rearming basically under scheduler control and the work happens in context of the task which asked for the signal.

There is a problem with that vs. SIG_IGN. If a signal has SIG_IGN installed as handler, the related signals are discarded. So in case of posix interval timers this means that such a timer is never rearmed even when SIG_IGN is replaced later with a real handler (including SIG_DFL).

To work around that the kernel self rearms those timers and throttles them when the interval is smaller than a tick to prevent a DoS.

That just keeps timers ticking, which obviously has effects on power and just creates work for nothing.

So ideally these timers should be stopped and rearmed when SIG_IGN is replaced, which aligns with the regular handling of posix timers.

Sounds trivial, but isn't:

1) Lock ordering.

The timer lock cannot be taken with sighand lock held which is problematic vs. the atomicity of sigaction().

2) Life time rules

The timer and the sigqueue are separate entities which requires a lookup of the timer ID in the signal rearm code. This can be handled, but the separate life time rules are not necessarily robust.

3) Finding the relevant timers

Obviosly it is possible to walk the posix timer list under sighand lock and handle it from there. That can be expensive especially in the case that there are no affected timers as the walk would just end up doing nothing.

The following series is a new and this time actually working attempt to solve this. It addresses it by:

1) Embedding the preallocated sigqueue into struct k_itimer, which makes the life time rules way simpler and just needs a trivial reference count.

2) Having a separate list in task::signal on which ignored timers are queued.

This avoids walking a potentially large timer list for nothing on a SIG_IGN to handler transition.

3) Requeueing the timers signal in the relevant signal queue so the timer is rearmed when the signal is actually delivered

That turned out to be the least complicated way to address the sighand lock vs. timer lock ordering issue.

With that timers which have their signal ignored are not longer self rearmed and the relevant workarounds including throttling for DoS prevention are removed.

The series is based on:

git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip timers/core

The series is also available from git:

git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git posixt-v7

Changes vs. V6:

- Update timer state consistently in posix_cpu_timer_del() - Frederic

- Cured the timer delete/exit issue vs. SIG_IGN - Frederic

- Use the proper list head in the exit path - Frederic

- Picked up Reviewed-by tags as appropriate

Thanks,

tglx

---
 drivers/power/supply/charger-manager.c |    3 
 fs/proc/base.c                         |    4 
 fs/timerfd.c                           |    4 
 include/linux/alarmtimer.h             |   10 
 include/linux/posix-timers.h           |   61 +++++
 include/linux/sched/signal.h           |    4 
 include/uapi/asm-generic/siginfo.h     |    2 
 init/init_task.c                       |    5 
 kernel/fork.c                          |    1 
 kernel/signal.c                        |  343 ++++++++++++++++++++++-----------
 kernel/time/alarmtimer.c               |   87 +-------
 kernel/time/posix-cpu-timers.c         |   59 +++--
 kernel/time/posix-timers.c             |  234 ++++++++++------------
 kernel/time/posix-timers.h             |    2 
 net/netfilter/xt_IDLETIMER.c           |    4 
 15 files changed, 463 insertions(+), 360 deletions(-)