posix-timers: Cure the SIG_IGN mess
Status from this message: The following commit has been merged into the timers/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v7 Latest21 patches 7 repliesApplied
- v620 patches 21 repliesSuperseded
- v526 patches 45 repliesApplied
Earlier versions · 4
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v4 | 27 patches | 8 replies | Superseded | |
| v3 | 51 patches | 17 replies | Superseded | |
| v2 | 50 patches | 36 replies | Superseded | |
| v1 | 45 patches | 20 replies | Superseded |
Changes in v7 from the cover letter
- Update timer state consistently in posix_cpu_timer_del() - Frederic
- Cured the timer delete/exit issue vs. SIG_IGN - Frederic
- Use the proper list head in the exit path - Frederic
- Picked up Reviewed-by tags as appropriate
Patches in v7 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/21 | posix-cpu-timers: Correctly update timer status in posix_cpu_timer_del()kernel/ | +6 | 1 reply | |
| 2/21 | posix-timers: Make signal delivery consistentinclude/ kernel/ kernel/ +1 more | +19 | 0 replies | |
| 3/21 | posix-timers: Make signal overrun accounting sensiblekernel/ kernel/ | +6 | 0 replies | |
| 4/21 | posix-cpu-timers: Cleanup the firing logicinclude/ kernel/ | +25 | 0 replies | |
| 5/21 | posix-cpu-timers: Use dedicated flag for CPU timer nanosleepinclude/ kernel/ | +4 | 0 replies | |
| 6/21 | posix-timers: Add a refcount to struct k_itimerinclude/ kernel/ | +18 | 0 replies | |
| 7/21 | signal: Split up __sigqueue_alloc()kernel/ | +35 | 0 replies | |
| 8/21 | signal: Provide posixtimer_sigqueue_init()include/ kernel/ | +13 | 0 replies | |
| 9/21 | posix-timers: Store PID type in the timerinclude/ kernel/ | +8 | 0 replies | |
| 10/21 | signal: Refactor send_sigqueue()include/ include/ kernel/ +1 more | +47 | 0 replies | |
| 11/21 | signal: Replace resched_timer logicinclude/ kernel/ kernel/ | +24 | 1 reply | |
| 12/21 | posix-timers: Embed sigqueue in struct k_itimerfs/ include/ kernel/ +1 more | +87 | 0 replies | |
| 13/21 | signal: Cleanup unused posix-timer leftoversinclude/ kernel/ | +4 | 0 replies | |
| 14/21 | posix-timers: Move sequence logic into struct k_itimerinclude/ include/ kernel/ +1 more | +7 | 0 replies | |
| 15/21 | signal: Provide ignored_posix_timers listinclude/ init/ kernel/ | +5 | 0 replies | |
| 16/21 | posix-timers: Handle ignored list on delete and exitinclude/ kernel/ | +31 | 1 reply | |
| 17/21 | signal: Handle ignored signals in do_sigaction(action != SIG_IGN)kernel/ | +52 | 0 replies | |
| 18/21 | signal: Queue ignored posixtimers on ignore listinclude/ kernel/ kernel/ | +83 | 1 reply | |
| 19/21 | posix-timers: Cleanup SIG_IGN workaround leftoversinclude/ kernel/ kernel/ +3 more | +24 | 1 reply | |
| 20/21 | alarmtimers: Remove the throttle mechanism from alarm_forward_now()kernel/ | +2 | 1 reply | |
| 21/21 | alarmtimers: Remove return value from alarm functionsdrivers/ fs/ include/ +2 more | +10 | 1 reply |
Reviews trailers per patch
All 21 patches have a Reviewed-by or Acked-by.
| Patch | Frederic Weisbecker | Peter Zijlstra (Intel) | Eric W. Biederman |
|---|---|---|---|
| 1/21 | R-b | ||
| 2/21 | R-b | ||
| 3/21 | R-b | A-b | |
| 4/21 | R-b | ||
| 5/21 | R-b | A-b | |
| 6/21 | R-b | A-b | |
| 7/21 | R-b | A-b | |
| 8/21 | R-b | A-b | |
| 9/21 | R-b | A-b | |
| 10/21 | R-b | A-b | |
| 11/21 | R-b | A-b | |
| 12/21 | R-b | A-b | |
| 13/21 | R-b | A-b | |
| 14/21 | R-b | A-b | |
| 15/21 | R-b | A-b | |
| 16/21 | R-b | A-b | |
| 17/21 | R-b | A-b | |
| 18/21 | R-b | A-b | |
| 19/21 | R-b | A-b | |
| 20/21 | R-b | A-b | |
| 21/21 | A-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [patch V7 00/21] posix-timers: Cure the SIG_IGN mess
This are the remaining bits to cure the SIG_IGN mess. Version 5 can be found here:
https://lore.kernel.org/lkml/[email protected]
Last year I reread a 15 years old comment about the SIG_IGN problem:
"FIXME: What we really want, is to stop this timer completely and restart
it in case the SIG_IGN is removed. This is a non trivial change which involves sighand locking (sigh !), which we don't want to do late in the release cycle. ... A more complex fix which solves also another related inconsistency is already in the pipeline."
The embarrasing part was that I put that comment in back then. So I went back and rumaged through old notes as I completely had forgotten why our attempts to fix this back then failed.
It turned out that the comment is about right: sighand locking and life time issues. So I sat down with the old notes and started to wrap my head around this again.
The problem to solve:
Posix interval timers are not rearmed automatically by the kernel for various reasons:
1) To prevent DoS by extremly short intervals.
2) To avoid timer overhead when a signal is pending and has not yet been delivered.
This is achieved by queueing the signal at timer expiry and rearming the timer at signal delivery to user space. This puts the rearming basically under scheduler control and the work happens in context of the task which asked for the signal.
There is a problem with that vs. SIG_IGN. If a signal has SIG_IGN installed as handler, the related signals are discarded. So in case of posix interval timers this means that such a timer is never rearmed even when SIG_IGN is replaced later with a real handler (including SIG_DFL).
To work around that the kernel self rearms those timers and throttles them when the interval is smaller than a tick to prevent a DoS.
That just keeps timers ticking, which obviously has effects on power and just creates work for nothing.
So ideally these timers should be stopped and rearmed when SIG_IGN is replaced, which aligns with the regular handling of posix timers.
Sounds trivial, but isn't:
1) Lock ordering.
The timer lock cannot be taken with sighand lock held which is problematic vs. the atomicity of sigaction().
2) Life time rules
The timer and the sigqueue are separate entities which requires a lookup of the timer ID in the signal rearm code. This can be handled, but the separate life time rules are not necessarily robust.
3) Finding the relevant timers
Obviosly it is possible to walk the posix timer list under sighand lock and handle it from there. That can be expensive especially in the case that there are no affected timers as the walk would just end up doing nothing.
The following series is a new and this time actually working attempt to solve this. It addresses it by:
1) Embedding the preallocated sigqueue into struct k_itimer, which makes the life time rules way simpler and just needs a trivial reference count.
2) Having a separate list in task::signal on which ignored timers are queued.
This avoids walking a potentially large timer list for nothing on a SIG_IGN to handler transition.
3) Requeueing the timers signal in the relevant signal queue so the timer is rearmed when the signal is actually delivered
That turned out to be the least complicated way to address the sighand lock vs. timer lock ordering issue.
With that timers which have their signal ignored are not longer self rearmed and the relevant workarounds including throttling for DoS prevention are removed.
The series is based on:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip timers/core
The series is also available from git:
git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git posixt-v7
Changes vs. V6:
- Update timer state consistently in posix_cpu_timer_del() - Frederic
- Cured the timer delete/exit issue vs. SIG_IGN - Frederic
- Use the proper list head in the exit path - Frederic
- Picked up Reviewed-by tags as appropriate
Thanks,
tglx
--- drivers/power/supply/charger-manager.c | 3 fs/proc/base.c | 4 fs/timerfd.c | 4 include/linux/alarmtimer.h | 10 include/linux/posix-timers.h | 61 +++++ include/linux/sched/signal.h | 4 include/uapi/asm-generic/siginfo.h | 2 init/init_task.c | 5 kernel/fork.c | 1 kernel/signal.c | 343 ++++++++++++++++++++++----------- kernel/time/alarmtimer.c | 87 +------- kernel/time/posix-cpu-timers.c | 59 +++-- kernel/time/posix-timers.c | 234 ++++++++++------------ kernel/time/posix-timers.h | 2 net/netfilter/xt_IDLETIMER.c | 4 15 files changed, 463 insertions(+), 360 deletions(-)