Skip to content

xen/arm: pl011: Use correct accessors

Michal Orzel xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4xen/arm: debug-pl011: Use correct accessorsxen/arch/arm/arm32/debug-pl011.inc xen/arch/arm/arm64/debug-pl011.inc+9 -94 replies
2/4xen/arm: debug-pl011: Add support for 32-bit only MMIOdocs/misc/arm/early-printk.txt xen/arch/arm/Kconfig.debug xen/arch/arm/arm32/debug-pl011.inc +2 more+41 -122 replies
3/4xen/arm: pl011: Use correct accessorsxen/drivers/char/pl011.c+47 -62 replies
4/4xen/arm: pl011: Add SBSA UART device-tree supportxen/drivers/char/pl011.c+6 -22 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchHenry WangStefano Stabellini
1/4T-b R-b
2/4T-b R-b
3/4T-b R-b
4/4R-b T-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] xen/arm: pl011: Use correct accessors

At the moment we have a real mix of accessors used for PL011 registers across early printk and runtime driver resulting in a) not spec compliant behavior and b) inconsistency. This series:
- switches to use the 8/16-bit accessors in normal case,
- adds support to use 32-bit only accessors.

The behavior is now the same as in Linux.

The last patch adding support for SBSA UART in dt boot was added to make the merge process easier. Also, arm,sbsa-uart property is usually present next to arm,pl011 which would casue the pl011 driver to believe it is driving PL011 and not SBSA, therefore resulting in accessing the registers that shall not be touched (as oppose to just failing).

Discussion:
https://lore.kernel.org/xen-devel/[email protected]/T/#

Michal Orzel (4):
xen/arm: debug-pl011: Use correct accessors xen/arm: debug-pl011: Add support for 32-bit only MMIO xen/arm: pl011: Use correct accessors xen/arm: pl011: Add SBSA UART device-tree support

 docs/misc/arm/early-printk.txt        |  3 ++
 xen/arch/arm/Kconfig.debug            |  7 ++++
 xen/arch/arm/arm32/debug-pl011.inc    | 12 +++---
 xen/arch/arm/arm64/debug-pl011.inc    | 12 +++---
 xen/arch/arm/include/asm/pl011-uart.h | 19 +++++++++
 xen/drivers/char/pl011.c              | 57 ++++++++++++++++++++++++---
 6 files changed, 92 insertions(+), 18 deletions(-)
Signature · 1 line
2.25.1