Skip to content

watchdog/hardlockup: Cleanup configuration of hardlockup detectors

Petr Mladek linux-perf-users linuxppc-dev lkml sparclinux 2 versions – Applied

Status from this message: [merged mm-nonmm-stable] watchdog-hardlockup-define-hardlockup_detector_arch.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 11 repliesApplied 6/6
  2. v17 patches 16 repliesSuperseded

Patches in v2 All 6 applied

#Subject and filesSizeRepliesApplied
1/6watchdog/hardlockup: Sort hardlockup detector related config values a logical waylib/Kconfig.debug+56 -561 replyApplied
2/6watchdog/hardlockup: Make the config checks more straightforwardarch/Kconfig lib/Kconfig.debug+53 -321 replyApplied
3/6watchdog/hardlockup: Declare arch_touch_nmi_watchdog() only in linux/nmi.harch/powerpc/include/asm/nmi.h arch/sparc/include/asm/nmi.h include/linux/nmi.h+10 -60 repliesApplied
4/6watchdog/hardlockup: Make HAVE_NMI_WATCHDOG sparc64-specificarch/Kconfig arch/sparc/Kconfig arch/sparc/Kconfig.debug +3 more+18 -332 repliesApplied
5/6watchdog/sparc64: Define HARDLOCKUP_DETECTOR_SPARC64arch/sparc/Kconfig.debug include/linux/nmi.h kernel/watchdog.c +1 more+10 -50 repliesApplied
6/6watchdog/hardlockup: Define HARDLOCKUP_DETECTOR_ARCHarch/powerpc/Kconfig include/linux/nmi.h lib/Kconfig.debug+12 -46 repliesApplied

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchDouglas Anderson
1/6R-b
2/6R-b
3/6R-b
4/6R-b
5/6R-b
6/6R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/6] watchdog/hardlockup: Cleanup configuration of hardlockup detectors

Hi,

this patchset is supposed to replace the last patch in the patchset cleaning up after introducing the buddy detector, see
https://lore.kernel.org/r/20230526184139.10.I821fe7609e57608913fe05abd8f35b343e7a9aae@changeid

Changes against v1:

+ Better explained the C-like ordering in the 1st patch.

+ Squashed patches for splitting and renaming HAVE_NMI_WATCHDOG, updated commit message with the history and more facts.

+ Updated comments about the sparc64 variant. It is not handled together with the softlockup detector. In fact, it is always build. And it even used to be always enabled until the commit 7a5c8b57cec93196b ("sparc:
implement watchdog_nmi_enable and watchdog_nmi_disable") added in v4.10-rc1.

I realized this when updating the comment for the 4th patch. My original statement in v1 patchset was based on code reading. I looked at it from a bad side.

+ Removed superfluous "default n"
+ Fixed typos.

Petr Mladek (6):
watchdog/hardlockup: Sort hardlockup detector related config values a
logical way
watchdog/hardlockup: Make the config checks more straightforward watchdog/hardlockup: Declare arch_touch_nmi_watchdog() only in
linux/nmi.h
watchdog/hardlockup: Make HAVE_NMI_WATCHDOG sparc64-specific watchdog/sparc64: Define HARDLOCKUP_DETECTOR_SPARC64 watchdog/hardlockup: Define HARDLOCKUP_DETECTOR_ARCH

 arch/Kconfig                   |  17 ++---
 arch/powerpc/Kconfig           |   5 +-
 arch/powerpc/include/asm/nmi.h |   2 -
 arch/sparc/Kconfig             |   2 +-
 arch/sparc/Kconfig.debug       |  14 ++++
 arch/sparc/include/asm/nmi.h   |   1 -
 include/linux/nmi.h            |  14 ++--
 kernel/watchdog.c              |   2 +-
 lib/Kconfig.debug              | 114 ++++++++++++++++++---------------
 9 files changed, 97 insertions(+), 74 deletions(-)
Signature · 1 line
2.35.3