Sacrifice your first born to the linter
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest15 patches 6 repliesIn review
Patches in v1 No applies recorded yet
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [oe-layersetup][PATCH 00/15] Sacrifice your first born to the linter
From: Randolph Sapp <[email protected]>
Last night someone in the beagle community reported some cryptic errors from oe-layersetup so I took the time to address all of the issues reported by Shellcheck and add some extra sanity checks.
I tried to split it into reasonable segments.
StaticRocket (15):
oe-layertool-setup: prefer use of $() notation
oe-layertool-setup: replace all x comparisons with -n/-z
oe-layertool-setup: fix all the printf calls
oe-layertool-setup: fix all quoting, switch eval to export
oe-layertool-setup: only invoke read with -r
oe-layertool-setup: check exit code directly
oe-layertool-setup: guard all cd calls
oe-layertool-setup: eliminate useless cat
oe-layertool-setup: use subshell execution with redirect
oe-layertool-setup: guard against invalid expression in case
oe-layertool-setup: replace all calls to echo with printf
oe-layertool-setup: drop unused variable
oe-layertool-setup: add a path sanity check for oebase
oe-layertool-setup: fix multi-line printfs
oe-layertool-setup: add sanity check for layer names
oe-layertool-setup.sh | 435 +++++++++++++++++++++--------------------- 1 file changed, 220 insertions(+), 215 deletions(-)
Signature · 1 line
2.40.1