revert shrinker_srcu related changes
Status from this message: [merged mm-hotfixes-stable] revert-mm-vmscan-make-global-slab-shrink-lockless.patch removed from -mm tree
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 7 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | Revert "mm: shrinkers: convert shrinker_rwsem to mutex"drivers/ drivers/ fs/ +2 more | +27 | 0 replies | Applied |
| 2/7 | Revert "mm: vmscan: remove shrinker_rwsem from synchronize_shrinkers()"mm/ | +6 | 0 replies | Applied |
| 3/7 | Revert "mm: vmscan: hold write lock to reparent shrinker nr_deferred"mm/ | +2 | 0 replies | Applied |
| 4/7 | Revert "mm: shrinkers: make count and scan in shrinker debugfs lockless"mm/ | +17 | 0 replies | Applied |
| 5/7 | Revert "mm: vmscan: add shrinker_srcu_generation"mm/ | +4 | 0 replies | Applied |
| 6/7 | Revert "mm: vmscan: make memcg slab shrink lockless"mm/ | +19 | 0 replies | Applied |
| 7/7 | Revert "mm: vmscan: make global slab shrink lockless"mm/ | +16 | 0 replies | Applied |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] revert shrinker_srcu related changes
From: Qi Zheng <[email protected]>
Hi all,
Kernel test robot reports -88.8% regression in stress-ng.ramfs.ops_per_sec test case [1], which is caused by commit f95bdb700bc6 ("mm: vmscan: make global slab shrink lockless"). The root cause is that SRCU has to be careful to not frequently check for SRCU read-side critical section exits. Therefore, even if no one is currently in the SRCU read-side critical section, synchronize_srcu() cannot return quickly. That's why unregister_shrinker() has become slower.
After discussion, we will try to use the refcount+RCU method [2] proposed by Dave Chinner to continue to re-implement the lockless slab shrink. So revert the shrinker_srcu related changes first.
[1]. https://lore.kernel.org/lkml/[email protected]/
[2]. https://lore.kernel.org/lkml/[email protected]/
And hi Andrew, the commit c3b5cb881de6 ("mm: vmscan: move shrinker_debugfs_remove() before synchronize_srcu()") is still in the mm-unstable branch, you can drop it directly.
This series is based on v6.4-rc5.
Thanks,
Qi
Qi Zheng (7):
Revert "mm: shrinkers: convert shrinker_rwsem to mutex" Revert "mm: vmscan: remove shrinker_rwsem from
synchronize_shrinkers()"
Revert "mm: vmscan: hold write lock to reparent shrinker nr_deferred" Revert "mm: shrinkers: make count and scan in shrinker debugfs
lockless"
Revert "mm: vmscan: add shrinker_srcu_generation"
Revert "mm: vmscan: make memcg slab shrink lockless" Revert "mm: vmscan: make global slab shrink lockless"
drivers/md/dm-cache-metadata.c | 2 +- drivers/md/dm-thin-metadata.c | 2 +- fs/super.c | 2 +- mm/shrinker_debug.c | 39 ++++++---- mm/vmscan.c | 125 +++++++++++++++------------------ 5 files changed, 82 insertions(+), 88 deletions(-)
Signature · 1 line
2.30.2