Skip to content

revert shrinker_srcu related changes

Qi Zheng linux-fsdevel linux-mm lkml 1 version Applied

Status from this message: [merged mm-hotfixes-stable] revert-mm-vmscan-make-global-slab-shrink-lockless.patch removed from -mm tree

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 0 repliesApplied 7/7

Patches in v1 All 7 applied

#Subject and filesSizeRepliesApplied
1/7Revert "mm: shrinkers: convert shrinker_rwsem to mutex"drivers/md/dm-cache-metadata.c drivers/md/dm-thin-metadata.c fs/super.c +2 more+27 -270 repliesApplied
2/7Revert "mm: vmscan: remove shrinker_rwsem from synchronize_shrinkers()"mm/vmscan.c+6 -20 repliesApplied
3/7Revert "mm: vmscan: hold write lock to reparent shrinker nr_deferred"mm/vmscan.c+2 -20 repliesApplied
4/7Revert "mm: shrinkers: make count and scan in shrinker debugfs lockless"mm/shrinker_debug.c+17 -80 repliesApplied
5/7Revert "mm: vmscan: add shrinker_srcu_generation"mm/vmscan.c+4 -200 repliesApplied
6/7Revert "mm: vmscan: make memcg slab shrink lockless"mm/vmscan.c+19 -260 repliesApplied
7/7Revert "mm: vmscan: make global slab shrink lockless"mm/vmscan.c+16 -120 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] revert shrinker_srcu related changes

From: Qi Zheng <[email protected]>

Hi all,

Kernel test robot reports -88.8% regression in stress-ng.ramfs.ops_per_sec test case [1], which is caused by commit f95bdb700bc6 ("mm: vmscan: make global slab shrink lockless"). The root cause is that SRCU has to be careful to not frequently check for SRCU read-side critical section exits. Therefore, even if no one is currently in the SRCU read-side critical section, synchronize_srcu() cannot return quickly. That's why unregister_shrinker() has become slower.

After discussion, we will try to use the refcount+RCU method [2] proposed by Dave Chinner to continue to re-implement the lockless slab shrink. So revert the shrinker_srcu related changes first.

[1]. https://lore.kernel.org/lkml/[email protected]/
[2]. https://lore.kernel.org/lkml/[email protected]/

And hi Andrew, the commit c3b5cb881de6 ("mm: vmscan: move shrinker_debugfs_remove() before synchronize_srcu()") is still in the mm-unstable branch, you can drop it directly.

This series is based on v6.4-rc5.

Thanks,
Qi

Qi Zheng (7):
Revert "mm: shrinkers: convert shrinker_rwsem to mutex" Revert "mm: vmscan: remove shrinker_rwsem from
synchronize_shrinkers()"
Revert "mm: vmscan: hold write lock to reparent shrinker nr_deferred" Revert "mm: shrinkers: make count and scan in shrinker debugfs
lockless"
Revert "mm: vmscan: add shrinker_srcu_generation"
Revert "mm: vmscan: make memcg slab shrink lockless" Revert "mm: vmscan: make global slab shrink lockless"

 drivers/md/dm-cache-metadata.c |   2 +-
 drivers/md/dm-thin-metadata.c  |   2 +-
 fs/super.c                     |   2 +-
 mm/shrinker_debug.c            |  39 ++++++----
 mm/vmscan.c                    | 125 +++++++++++++++------------------
 5 files changed, 82 insertions(+), 88 deletions(-)
Signature · 1 line
2.30.2