RFC fixed worker
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest11 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | io-wq: fix worker counting after worker received exit signalio_uring/ | +4 | 1 reply | |
| 2/11 | io-wq: add a new worker flag to indicate worker exitio_uring/ | +13 | 1 reply | |
| 3/11 | io-wq: add a new type io-wq workerio_uring/ | +12 | 1 reply | |
| 4/11 | io-wq: add fixed worker members in io_wq_acctio_uring/ | +2 | 0 replies | |
| 5/11 | io-wq: add a new parameter for creating a new fixed workerio_uring/ | +20 | 1 reply | |
| 6/11 | io-wq: return io_worker after successful inline worker creationio_uring/ | +10 | 1 reply | |
| 7/11 | io_uring: add new api to register fixed workersinclude/ io_uring/ io_uring/ +1 more | +166 | 5 replies | |
| 8/11 | io_uring: add function to unregister fixed workersinclude/ io_uring/ io_uring/ +1 more | +98 | 1 reply | |
| 9/11 | io-wq: add strutures to allow to wait fixed workers exitio_uring/ | +52 | 0 replies | |
| 10/11 | io-wq: distinguish fixed worker by its nameio_uring/ | +4 | 1 reply | |
| 11/11 | io_uring: add IORING_SETUP_FIXED_WORKER_ONLY and its friendinclude/ io_uring/ io_uring/ +1 more | +42 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 00/11] fixed worker
From: Hao Xu <[email protected]>
The initial feature request by users is here:
https://github.com/axboe/liburing/issues/296
Fixed worker provide a way for users to control the io-wq threads. A fixed worker is worker thread which exists no matter there are works to do or not. We provide a new register api to register fixed workers, and a register api to unregister them as well. The parameter of the register api is the number of fixed workers users want.
For example:
```c
io_uring_register_iowq_fixed_workers(&ring, { .nr_workers = 5 })
do I/O works
io_uring_unregister_iowq_fixed_workers(&ring)
```After registration, there will be 5 fixed workers. User can setup their affinity, priority etc. freely, without adding any new register api to set up attributions. These workers won't be destroyed until users call unregister api.
Note, registering some fixed workers doesn't mean no creating normal workers. When there is no free workers, new normal workers can be created when works come. So a work may be picked up by fixed workers or normal workers.
If users want to offload works only to fixed workers, they can specify a flag FIXED_ONLY when registering fixed workers.
```c
io_uring_register_iowq_fixed_workers(&ring, { .nr_workers = 5, .flags |=
FIXED_ONLY })
```In above case, no normal workers will be created before calling io_uring_register_iowq_fixed_workers().
Note:
- When registering fixed workers, those fixed workers are per io-wq. So if an io_uring instance is shared by multiple tasks, and you want all tasks to use fixed workers, all tasks have to call the regitser api.
- if specifying FIXED_ONLY when registering fixed workers, that is per io_uring instance. all works in this instance are handled by fixed workers.
Therefore, if an io_uring instance is shared by two tasks, and you want all requests in this instance to be handled only by fixed workers, you have to call the register api in these two tasks and specify FIXED_ONLY at least once when calling register api.
Hao Xu (11):
io-wq: fix worker counting after worker received exit signal
io-wq: add a new worker flag to indicate worker exit
io-wq: add a new type io-wq worker
io-wq: add fixed worker members in io_wq_acct
io-wq: add a new parameter for creating a new fixed worker
io-wq: return io_worker after successful inline worker creation
io_uring: add new api to register fixed workers
io_uring: add function to unregister fixed workers
io-wq: add strutures to allow to wait fixed workers exit
io-wq: distinguish fixed worker by its name
io_uring: add IORING_SETUP_FIXED_WORKER_ONLY and its friend
include/uapi/linux/io_uring.h | 20 +++ io_uring/io-wq.c | 275 ++++++++++++++++++++++++++++++---- io_uring/io-wq.h | 3 + io_uring/io_uring.c | 132 +++++++++++++++- 4 files changed, 397 insertions(+), 33 deletions(-)
Signature · 1 line
2.25.1