leds: trigger: netdev: add additional modes
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v5 Latest3 patches 6 repliesApplied 3/3
- v43 patches 9 repliesSuperseded
- v32 patches 1 replySuperseded
Earlier versions · 2
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v2 | 2 patches | 3 replies | Superseded | |
| v1 | 3 patches | 2 replies | Superseded |
Changes in v5 from the cover letter
- Fix conflict error on rebase
- Add Review-by tag by Andrew
Patches in v5 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | leds: trigger: netdev: add additional specific link speed modedrivers/ include/ | +73 | 1 reply | Applied |
| 2/3 | leds: trigger: netdev: add additional specific link duplex modedrivers/ include/ | +27 | 1 reply | Applied |
| 3/3 | leds: trigger: netdev: expose hw_control status via sysfsdrivers/ | +11 | 4 replies | Applied |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Andrew Lunn | Kalesh AP | Lee Jones |
|---|---|---|---|
| 1/3 | R-b | A-b | |
| 2/3 | R-b | A-b | |
| 3/3 | R-b | R-b | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [net-next PATCH v5 0/3] leds: trigger: netdev: add additional modes
This is a continue of [1]. It was decided to take a more gradual approach to implement LEDs support for switch and phy starting with basic support and then implementing the hw control part when we have all the prereq done.
This should be the final part for the netdev trigger.
I added net-next tag and added netdev mailing list since I was informed that this should be merged with netdev branch.
We collect some info around and we found a good set of modes that are common in almost all the PHY and Switch.
These modes are:
- Modes for dedicated link speed(10, 100, 1000 mbps). Additional mode can be added later following this example.
- Modes for half and full duplex.
The original idea was to add hw control only modes.
While the concept makes sense in practice it would results in lots of additional code and extra check to make sure we are setting correct modes.
With the suggestion from Andrew it was pointed out that using the ethtool APIs we can actually get the current link speed and duplex and this effectively removed the problem of having hw control only modes since we can fallback to software.
Since these modes are supported by software, we can skip providing an user for this in the LED driver to support hw control for these new modes (that will come right after this is merged) and prevent this to be another multi subsystem series.
For link speed and duplex we use ethtool APIs.
To call ethtool APIs, rtnl lock is needed but this can be skipped on handling netdev events as the lock is already held.
[1] https://lore.kernel.org/lkml/[email protected]/
Changes v5:
- Fix conflict error on rebase
- Add Review-by tag by Andrew
Changes v4:
- Add net-next tag
- Add additional patch to expose hw_control via sysfs
- CC netdev mailing list
Changes v3:
- Add Andrew review tag
- Use SPEED_UNKNOWN to init link_speed
- Fix using HALF_DUPLEX as duplex init and use DUPLEX_UNKNOWN instead Changes v2:
- Drop ACTIVITY patch as it can be handled internally in the LED driver
- Reduce duplicate code and move the link state to a dedicated helper
Christian Marangi (3):
leds: trigger: netdev: add additional specific link speed mode
leds: trigger: netdev: add additional specific link duplex mode
leds: trigger: netdev: expose hw_control status via sysfs
drivers/leds/trigger/ledtrig-netdev.c | 114 +++++++++++++++++++++++--- include/linux/leds.h | 5 ++ 2 files changed, 109 insertions(+), 10 deletions(-)
Signature · 1 line
2.40.1