Skip to content

RFC tracing/filters: filtering event fields with a cpumask

Valentin Schneider linux-doc linux-trace-kernel lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5tracing/filters: Dynamically allocate filter_pred.regexkernel/trace/trace_events_filter.c+37 -250 replies
2/5tracing/filters: Enable filtering a cpumask field by another cpumaskinclude/linux/trace_events.h kernel/trace/trace_events_filter.c+84 -20 replies
3/5tracing/filters: Enable filtering a scalar field by a cpumaskkernel/trace/trace_events_filter.c+80 -120 replies
4/5tracing/filters: Enable filtering the CPU common field by a cpumaskkernel/trace/trace_events_filter.c+13 -00 replies
5/5tracing/filters: Document cpumask filteringDocumentation/trace/events.rst+14 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/5] tracing/filters: filtering event fields with a cpumask

Hi folks,

In the context of CPU isolation / NOHZ_FULL interference investigation, we now have the ipi_send_cpu and ipi_send_cpumask events. However, enabling these events without any filtering can yield pretty massive traces with a lot of uninteresting or irrelevant data (e.g. everything targeting housekeeping CPUs).

This series is about adding event filtering via a user-provided cpumask. This enables filtering using cpumask fields (e.g. ipi_send_cpumask) and extends this to scalar and the local CPU common fields.

With this, it becomes fairly easy to trace events both happening on and targeting CPUs of interest, e.g.:

  trace-cmd record -e 'sched_switch' -f "CPU & MASK{$ISOLATED_CPUS}"         \
		   -e 'sched_wakeup' -f "target_cpu & MASK{$ISOLATED_CPUS}"  \
		   -e 'ipi_send_cpu' -f "cpu & MASK{$ISOLATED_CPUS}"         \
		   -e 'ipi_send_cpumask' -f "cpumask & MASK{$ISOLATED_CPUS}" \
		   hackbench

The MASK{} thing is a bit crude but seems to work well enough without break^C overhauling the predicate parsing logic.

Cheers,
Valentin

Valentin Schneider (5):
tracing/filters: Dynamically allocate filter_pred.regex tracing/filters: Enable filtering a cpumask field by another cpumask tracing/filters: Enable filtering a scalar field by a cpumask tracing/filters: Enable filtering the CPU common field by a cpumask tracing/filters: Document cpumask filtering

 Documentation/trace/events.rst     |  14 ++
 include/linux/trace_events.h       |   1 +
 kernel/trace/trace_events_filter.c | 228 +++++++++++++++++++++++++----
 3 files changed, 216 insertions(+), 27 deletions(-)

--
2.31.1