Skip to content

Support writable CPU ID registers from userspace

Oliver Upton kvmarm linux-arm-kernel 1 version Applied

Status from this message: Applied to kvmarm/next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v12 Latest11 patches 5 repliesApplied

Patches in v12 Applied

#Subject and filesSizeRepliesApplied
1/11KVM: arm64: Separate out feature sanitisation and initialisationarch/arm64/include/asm/kvm_host.h arch/arm64/kvm/arm.c+48 -280 replies
2/11KVM: arm64: Relax invariance of KVM_ARM_VCPU_POWER_OFFarch/arm64/kvm/arm.c+12 -10 replies
3/11KVM: arm64: Make vCPU feature flags consistent VM-widearch/arm64/include/asm/kvm_emulate.h arch/arm64/include/asm/kvm_host.h arch/arm64/kvm/arm.c +1 more+40 -780 replies
4/11KVM: arm64: Rewrite IMPDEF PMU version as NIarch/arm64/include/asm/kvm_host.h arch/arm64/kvm/arm.c arch/arm64/kvm/sys_regs.c +1 more+38 -270 replies
5/11KVM: arm64: Reuse fields of sys_reg_desc for idregarch/arm64/kvm/sys_regs.c arch/arm64/kvm/sys_regs.h+84 -250 replies
6/11KVM: arm64: Save ID registers' sanitized value per guestarch/arm64/include/asm/kvm_host.h arch/arm64/kvm/sys_regs.c arch/arm64/kvm/sys_regs.h+75 -30 replies
7/11KVM: arm64: Use arm64_ftr_bits to sanitise ID register writesarch/arm64/include/asm/cpufeature.h arch/arm64/kernel/cpufeature.c arch/arm64/kvm/sys_regs.c+111 -52 replies
8/11KVM: arm64: Use generic sanitisation for ID_(AA64)DFR0_EL1arch/arm64/kvm/sys_regs.c+61 -450 replies
9/11KVM: arm64: Use generic sanitisation for ID_AA64PFR0_EL1arch/arm64/kvm/sys_regs.c+45 -210 replies
10/11KVM: arm64: Handle ID register reads using the VM-wide valuesarch/arm64/kvm/sys_regs.c+13 -10 replies
11/11KVM: arm64: Rip out the vestiges of the 'old' ID register schemearch/arm64/include/asm/kvm_host.h arch/arm64/kvm/arm.c arch/arm64/kvm/sys_regs.c +1 more+10 -1170 replies

Reviews trailers per patch

None of the 11 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMarc Zyngier
SeriesR-b
1/11
2/11
3/11
4/11
5/11
6/11
7/11
8/11
9/11
10/11
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v12 thread

Cover letter [PATCH v12 00/11] Support writable CPU ID registers from userspace

Hello folks,

In the interest of expediting the acceptance of the generalized ID register infrastructure, I have taken Jing's series and applied fixes according to the feedback of reviewers and my own interpretation.

The laundry list:
- Split and reorganize the changes to avoid introducing intermediate regressions in the series. Don't want to break bisection! Sadly, this requires introducing a bit of churn but to me is an acceptable tradeoff.

- Split up monster changes into more bite-sized chunks.

- Actually delete the old masking logic when we no longer use it.

- Reinterpret IMP_DEF PMUs as NI at the time of write

- Move locking back into ID reg specific code. Let it be known: if you want to do custom ->set_user() logic for an ID register, it better find its way into set_id_reg().

- Rewrite kvm_vcpu_set_target() into something that's a bit more cognizant of the existence of a bitmap.

- Prevent userspace from configuring asymmetric vCPU features. Yep, this is technically user-visible breakage, but has been a long time coming. Asymmetry in KVM has always worked by chance, and is inconsistent with the overall handling of asymmetry in the kernel. If this breaks you: now's your chance to plead your usecase.

- Rip out the PMUVer <-> PerfMon bidirectional pipe. Making things consistent between the 32bit and 64bit worlds is needlessly complicated, and the only thing we care about in KVM is that the advertised feature set aligns with the limits of the system/VM.

- Allow the value of KVM_ARM_VCPU_POWER_OFF to change between calls. It doesn't make sense in the context of a VM-wide feature set, and we may as well let userspace do whatever it wants with the bit.

- Opportunistically rewrite sysreg definitions to use the new syntax.

Tested with selftests, kvm-unit-tests, as well as booting an actual VM with kvmtool + QEMU.

v11: https://lore.kernel.org/kvmarm/[email protected]/

Jing Zhang (5):
KVM: arm64: Reuse fields of sys_reg_desc for idreg
KVM: arm64: Save ID registers' sanitized value per guest
KVM: arm64: Use arm64_ftr_bits to sanitise ID register writes
KVM: arm64: Use generic sanitisation for ID_(AA64)DFR0_EL1
KVM: arm64: Use generic sanitisation for ID_AA64PFR0_EL1

Oliver Upton (6):
KVM: arm64: Separate out feature sanitisation and initialisation
KVM: arm64: Relax invariance of KVM_ARM_VCPU_POWER_OFF
KVM: arm64: Make vCPU feature flags consistent VM-wide
KVM: arm64: Rewrite IMPDEF PMU version as NI
KVM: arm64: Handle ID register reads using the VM-wide values
KVM: arm64: Rip out the vestiges of the 'old' ID register scheme

 arch/arm64/include/asm/cpufeature.h  |   1 +
 arch/arm64/include/asm/kvm_emulate.h |   7 +-
 arch/arm64/include/asm/kvm_host.h    |  45 +--
 arch/arm64/kernel/cpufeature.c       |   2 +-
 arch/arm64/kvm/arm.c                 | 134 +++++---
 arch/arm64/kvm/reset.c               |  58 ----
 arch/arm64/kvm/sys_regs.c            | 493 +++++++++++++++++++--------
 arch/arm64/kvm/sys_regs.h            |  22 +-
 include/kvm/arm_pmu.h                |   8 +-
 9 files changed, 478 insertions(+), 292 deletions(-)

base-commit: 7877cb91f1081754a1487c144d85dc0d2e2e7fc4

Signature · 1 line
2.41.0.162.gfafddb0af9-goog