Skip to content

NFSv4.2: Various READ_PLUS fixes

Anna Schumaker linux-nfs 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest5 patches 1 replyIn review
  2. v55 patches 2 repliesSuperseded
  3. v44 patches 2 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v33 patches3 repliesSuperseded
v23 patches0 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5NFSv4.2: Fix READ_PLUS smatch warningsfs/nfs/nfs42xdr.c+1 -20 replies
2/5NFSv4.2: Fix READ_PLUS size calculationsfs/nfs/nfs42xdr.c+9 -30 replies
3/5NFSv4.2: Rework scratch handling for READ_PLUS (again)fs/nfs/internal.h fs/nfs/nfs42.h fs/nfs/nfs42xdr.c +2 more+14 -130 replies
4/5SUNRPC: kmap() the xdr pages during decodeinclude/linux/sunrpc/xdr.h net/sunrpc/clnt.c net/sunrpc/svc.c +1 more+32 -11 reply
5/5NFS: Enable the READ_PLUS operation by defaultfs/nfs/Kconfig+2 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/5] NFSv4.2: Various READ_PLUS fixes

From: Anna Schumaker <[email protected]>

These patches are a handul of fixes I've done recently to the READ_PLUS code. This includes fixing some smatch warnings, fixing the XDR reply length calculation, improving scratch buffer handling, and having xdr_inline_decode() kmap pages if we detect that they're HIGHMEM so we don't oops during READ_PLUS xdr decoding.

I also (optimistically) have a patch at the end to enable CONFIG_READ_PLUS by default. My hope right now is that we can enable READ_PLUS for Linux 6.6, and remove it entirely in 6.7 if all goes well.

Thoughts? Patch #4 probably needs the most review, and I'm open to other approaches if something else makes more sense!

Thanks,
Anna

Anna Schumaker (5):
NFSv4.2: Fix READ_PLUS smatch warnings NFSv4.2: Fix READ_PLUS size calculations NFSv4.2: Rework scratch handling for READ_PLUS (again)
SUNRPC: kmap() the xdr pages during decode
NFS: Enable the READ_PLUS operation by default

 fs/nfs/Kconfig             |  6 ++----
 fs/nfs/internal.h          |  1 +
 fs/nfs/nfs42.h             |  1 +
 fs/nfs/nfs42xdr.c          | 17 +++++++++++------
 fs/nfs/nfs4proc.c          | 13 +------------
 fs/nfs/read.c              | 10 ++++++++++
 include/linux/sunrpc/xdr.h |  3 +++
 net/sunrpc/clnt.c          |  1 +
 net/sunrpc/svc.c           |  2 ++
 net/sunrpc/xdr.c           | 27 ++++++++++++++++++++++++++-
 10 files changed, 58 insertions(+), 23 deletions(-)
Signature · 1 line
2.41.0