Skip to content

net: support extack in dump and simplify ethtool uAPI

Jakub Kicinski netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesApplied 2/2

Patches in v1 All 2 applied

#Subject and filesSizeRepliesApplied
1/2netlink: support extack in dump ->start()include/linux/netlink.h net/netlink/af_netlink.c net/netlink/genetlink.c+5 -00 repliesApplied
2/2net: ethtool: don't require empty header nestsnet/ethtool/netlink.c+2 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH net-next 0/2] net: support extack in dump and simplify ethtool uAPI

Ethtool currently requires header nest to be always present even if it doesn't have to carry any attr for a given request. This inflicts unnecessary pain on the users.

What makes it worse is that extack was not working in dump's ->start() callback. Address both of those issues.

Jakub Kicinski (2):
netlink: support extack in dump ->start()
net: ethtool: don't require empty header nests

 include/linux/netlink.h  | 1 +
 net/ethtool/netlink.c    | 2 ++
 net/netlink/af_netlink.c | 2 ++
 net/netlink/genetlink.c  | 2 ++
 4 files changed, 7 insertions(+)
Signature · 1 line
2.40.1