Skip to content

Revert broken Bootmenu commits

Pali Rohár u-boot 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Revert "video: Enable VIDEO_ANSI by default only with EFI"drivers/video/Kconfig+2 -50 replies
2/3Revert "menu: Factor out menu-keypress decoding"common/menu.c include/menu.h+18 -400 replies
3/3Revert "menu: Make use of CLI character processing"cmd/bootmenu.c cmd/eficonfig.c common/cli_getch.c +3 more+80 -560 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH u-boot 0/3] Revert broken Bootmenu commits

These 3 commits broke support for U-Boot Bootmenu on Nokia N900. Issues were reported more than month ago, but nobody reacted to them. So revert these broken commits for now, to fix U-Boot Bootmenu support.

With these revered commits, U-Boot Bootmenu from master branch is working fine again on Nokia N900.

Pali Rohár (3):
Revert "video: Enable VIDEO_ANSI by default only with EFI" Revert "menu: Factor out menu-keypress decoding" Revert "menu: Make use of CLI character processing"

 cmd/bootmenu.c        |   9 ++--
 cmd/eficonfig.c       |  12 ++---
 common/cli_getch.c    |  12 ++---
 common/menu.c         | 122 ++++++++++++++++++++++++++----------------
 drivers/video/Kconfig |   7 +--
 include/cli.h         |   4 +-
 include/menu.h        |  17 +-----
 7 files changed, 91 insertions(+), 92 deletions(-)
Signature · 1 line
2.20.1