Skip to content

block: fine-granular CAP_SYS_ADMIN for Persistent Reservation ioctl

Jingbo Xu linux-block lkml 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesApplied
  2. v21 patch 2 repliesSuperseded

Changes in v3 from the cover letter

- patch 1: disallow reservations on partitions entirely and make it into a separate patch (hch)
- patch 2: rebase to hch's series of converting fmode_t to blk_mode_t and execute permission check upon blk_mode_t (hch)

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/2block: disallow Persistent Reservation on partitionsblock/ioctl.c+17 -51 reply
2/2block: fine-granular CAP_SYS_ADMIN for Persistent Reservationblock/ioctl.c+22 -191 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchChristoph Hellwig
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH v3 0/2] block: fine-granular CAP_SYS_ADMIN for Persistent Reservation ioctl

changes since v2:
- patch 1: disallow reservations on partitions entirely and make it into a separate patch (hch)
- patch 2: rebase to hch's series of converting fmode_t to blk_mode_t and execute permission check upon blk_mode_t (hch)

changes since RFC:
- only allow unprivileged reservations if the file descriptor is open for write (Christoph Hellwig)
- refuse the unprivileged reservations on partitions (Christoph Hellwig) (maybe this checking shall also be done when CAP_SYS_ADMIN is set?)

RFC: https://lore.kernel.org/all/[email protected]/
v2: https://lore.kernel.org/all/[email protected]/

Jingbo Xu (2):
block: disallow Persistent Reservation on partitions
block: fine-granular CAP_SYS_ADMIN for Persistent Reservation

 block/ioctl.c | 47 +++++++++++++++++++++++++++++++----------------
 1 file changed, 31 insertions(+), 16 deletions(-)
Signature · 1 line
2.19.1.6.gb485710b