Skip to content

virtio-mem: Device unplug support

David Hildenbrand qemu-arm qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 3 repliesIn review
  2. v37 patches 7 repliesSuperseded
  3. v27 patches 0 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v15 patches3 repliesSuperseded

Changes in v4 from the cover letter

- "pc: Factor out (un)plug handling of virtio-md-pci devices" -> Add stubs to fix arm64 compilation under mingw
- Added Tested-by's

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7virtio-md-pci: New parent type for virtio-mem-pci and virtio-pmem-pciMAINTAINERS hw/virtio/Kconfig hw/virtio/meson.build +6 more+89 -160 replies
2/7pc: Factor out (un)plug handling of virtio-md-pci devicesMAINTAINERS hw/i386/pc.c hw/virtio/virtio-md-pci.c +3 more+106 -790 replies
3/7arm/virt: Use virtio-md-pci (un)plug functionshw/arm/virt.c+12 -690 replies
4/7virtio-md-pci: Handle unplug of virtio based memory deviceshw/virtio/virtio-md-pci.c+22 -10 replies
5/7virtio-md-pci: Support unplug requests for compatible deviceshw/virtio/virtio-md-pci.c include/hw/virtio/virtio-md-pci.h+39 -20 replies
6/7virtio-mem: Prepare for device unplug supporthw/virtio/virtio-mem.c include/hw/virtio/virtio-mem.h+26 -00 replies
7/7virtio-mem-pci: Device unplug supporthw/virtio/virtio-mem-pci.c+46 -30 replies

Reviews trailers per patch

None of the 7 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMario CasqueroMichael S. Tsirkin
SeriesR-b
1/7T-b
2/7T-b
3/7T-b
4/7T-b
5/7T-b
6/7T-b
7/7T-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] virtio-mem: Device unplug support

One limitation of virtio-mem is that we cannot currently unplug virtio-mem devices that have all memory unplugged from the VM.

Let's properly handle forced unplug (as can be triggered by the VM) and add support for ordinary unplug (requests) of virtio-mem devices that are in a compatible state (no legacy mode, no plugged memory, no plug request).

Briefly tested on both, x86_64 and aarch64.

v3 -> v4:
- "pc: Factor out (un)plug handling of virtio-md-pci devices" -> Add stubs to fix arm64 compilation under mingw
- Added Tested-by's

v2 -> v3:
- "virtio-md-pci: New parent type for virtio-mem-pci and virtio-pmem-pci" -> Add MAINTAINERS entry

v1 -> v2:
- Reduce code duplication and implement it in a cleaner way using a new abstract virtio-md-pci parent class
- "virtio-md-pci: New parent type for virtio-mem-pci and virtio-pmem-pci" -> Added, use a new aprent type like virtio-input-pci
- "pc: Factor out (un)plug handling of virtio-md-pci devices" -> Added, factor it cleanly out
- "arm/virt: Use virtio-md-pci (un)plug functions"
-> Added, reduce code duplciation
- "virtio-md-pci: Handle unplug of virtio based memory devices" -> More generic without any device-specifics
- "virtio-md-pci: Support unplug requests for compatible devices" -> More generic without any device-specifics
- "virtio-mem: Prepare for device unplug support"
-> Use callback, separated from virtio-mem-pci device change
- "virtio-mem-pci: Device unplug support"
-> Use callback, separated from virtio-mem device change

Cc Peter Maydell <[email protected]>
Cc Paolo Bonzini <[email protected]>
Cc Richard Henderson <[email protected]>
Cc Eduardo Habkost <[email protected]>
Cc "Michael S. Tsirkin" <[email protected]>
Cc Marcel Apfelbaum <[email protected]>
Cc Igor Mammedov <[email protected]>
Cc Gavin Shan <[email protected]>
Cc Mario Casquero <[email protected]>

David Hildenbrand (7):
virtio-md-pci: New parent type for virtio-mem-pci and virtio-pmem-pci
pc: Factor out (un)plug handling of virtio-md-pci devices arm/virt: Use virtio-md-pci (un)plug functions
virtio-md-pci: Handle unplug of virtio based memory devices
virtio-md-pci: Support unplug requests for compatible devices
virtio-mem: Prepare for device unplug support
virtio-mem-pci: Device unplug support

 MAINTAINERS                       |   7 ++
 hw/arm/virt.c                     |  81 +++-------------
 hw/i386/pc.c                      |  90 +++---------------
 hw/virtio/Kconfig                 |   8 +-
 hw/virtio/meson.build             |   1 +
 hw/virtio/virtio-md-pci.c         | 151 ++++++++++++++++++++++++++++++
 hw/virtio/virtio-mem-pci.c        |  54 +++++++++--
 hw/virtio/virtio-mem-pci.h        |   6 +-
 hw/virtio/virtio-mem.c            |  25 +++++
 hw/virtio/virtio-pmem-pci.c       |   5 +-
 hw/virtio/virtio-pmem-pci.h       |   6 +-
 include/hw/virtio/virtio-md-pci.h |  44 +++++++++
 include/hw/virtio/virtio-mem.h    |   1 +
 stubs/meson.build                 |   1 +
 stubs/virtio-md-pci.c             |  24 +++++
 15 files changed, 337 insertions(+), 167 deletions(-)
 create mode 100644 hw/virtio/virtio-md-pci.c
 create mode 100644 include/hw/virtio/virtio-md-pci.h
 create mode 100644 stubs/virtio-md-pci.c
Signature · 1 line
2.41.0