Skip to content

tool/perf/test: Fix shellcheck coding/formatting issues of test shell scripts

Athira Rajeev linux-perf-users linuxppc-dev 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 22 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/17perf: get rid of unused importtools/perf/scripts/python/arm-cs-trace-disasm.py+0 -14 replies
2/17tools/perf/tests: fix shellcheck warning for stat+json_outputtools/perf/tests/shell/stat+json_output.sh+1 -10 replies
3/17shellcheck : fixing signal names and adding double quotes for expression in test_arm_callgraph_fptools/perf/tests/shell/test_arm_callgraph_fp.sh+3 -30 replies
4/17tools/perf/tests: fix shellcheck warnings for daemon.shtools/perf/tests/shell/daemon.sh+75 -380 replies
5/17tools/perf/tests: Fix shellcheck warnings for stat+csv_outputtools/perf/tests/shell/stat+csv_output.sh+2 -20 replies
6/17tools/perf/tests: Fix shellcheck warnings for trace+probe_vfs_getname.shtools/perf/tests/shell/trace+probe_vfs_getname.sh+3 -31 reply
7/17perf/tests/shell : Shellcheck fixes for perf test "test_arm_coresight.sh"tools/perf/tests/shell/test_arm_coresight.sh+3 -30 replies
8/17tools/perf/tests/shell/stat_all_metrics: Fix shellcheck warning SC2076 in stat_all_metrics.shtools/perf/tests/shell/stat_all_metrics.sh+3 -30 replies
9/17tools/perf/tests: Fix shellcheck issues in test_task_analyzer.sh filetools/perf/tests/shell/test_task_analyzer.sh+27 -270 replies
10/17tools/perf/tests: fix test_arm_spe.sh signal case issuestools/perf/tests/shell/test_arm_spe.sh+1 -10 replies
11/17perf/tests/shell: fix shellscript errors for lock_contention.shtools/perf/tests/shell/lock_contention.sh+35 -350 replies
12/17tools/perf/tests: fixed shellcheck warnings for perf shell scriptstools/perf/tests/shell/buildid.sh tools/perf/tests/shell/record+probe_libc_inet_pton.sh tools/perf/tests/shell/record+script_probe_vfs_getname.sh+11 -110 replies
13/17tools/perf/tests: Fix all POSIX sh warnings in perf shell test test_brstack.shtools/perf/tests/shell/test_brstack.sh+6 -60 replies
14/17tools/perf/tests: Fix all POSIX sh warnings in stat+shadow_stat.shtools/perf/tests/shell/stat+shadow_stat.sh+2 -20 replies
15/17perf tests task_analyzer: fix bad substitution ${$1}tools/perf/tests/shell/test_task_analyzer.sh+1 -111 replies
16/17perf tests task_analyzer: print command on failuretools/perf/tests/shell/test_task_analyzer.sh+12 -122 replies
17/17perf tests task_analyzer: skip tests if no libtraceevent supporttools/perf/tests/shell/test_task_analyzer.sh+18 -02 replies

Reviews trailers per patch

2 of 17 patches have a Reviewed-by or Acked-by.

PatchHagen Paul PfeiferLeo Yan
1/17R-b
2/17
3/17
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17A-b
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/17] tool/perf/test: Fix shellcheck coding/formatting issues of test shell scripts

Patchset covers a set of fixes for coding/formatting issues observed while running shellcheck tool on the perf test shell scripts. Shellcheck is a static analysis tool that can find semantic/syntax bugs in the shell scripts.

Patches 1-14 fixes the issues found with shellcheck. Patch 15, 16 and patch 17 address a fix in task_analyzer test.

This cleanup is a pre-requisite to include a build option for shellcheck discussed here: https://www.spinics.net/lists/linux-perf-users/msg25553.html
Also this is first set of patches. There will be one more set which will include build option for shellcheck as discussed in the mail thread.

Abhirup Deb (2):
tools/perf/tests: fix test_arm_spe.sh signal case issues perf/tests/shell: fix shellscript errors for lock_contention.sh

Aboorva Devarajan (1):
tools/perf/tests: Fix shellcheck issues in test_task_analyzer.sh file

Aditya Gupta (3):
perf tests task_analyzer: fix bad substitution ${$1} perf tests task_analyzer: print command on failure perf tests task_analyzer: skip tests if no libtraceevent support

Akanksha J N (1):
tools/perf/tests: Fix shellcheck warnings for
trace+probe_vfs_getname.sh

Anushree Mathur (1):
perf/tests/shell : Shellcheck fixes for perf test
"test_arm_coresight.sh"

Barnali Guha Thakurata (1):
tools/perf/tests/shell/stat_all_metrics: Fix shellcheck warning SC2076
in stat_all_metrics.sh

Disha Goel (1):
tools/perf/tests: fix shellcheck warning for stat+json_output

Geetika (1):
tools/perf/tests: Fix all POSIX sh warnings in perf shell test
test_brstack.sh

Korrapati Likhitha (1):
tools/perf/tests: Fix shellcheck warnings for stat+csv_output

Samir Mulani (1):
tools/perf/tests: fixed shellcheck warnings for perf shell scripts

Shirisha G (1):
tools/perf/tests: fix shellcheck warnings for daemon.sh

Sourabh Jain (1):
perf: get rid of unused import

Spoorthy S (2):
shellcheck : fixing signal names and adding double quotes for
expression in test_arm_callgraph_fp
tools/perf/tests: Fix all POSIX sh warnings in stat+shadow_stat.sh

 .../scripts/python/arm-cs-trace-disasm.py     |   1 -
 tools/perf/tests/shell/buildid.sh             |  12 +-
 tools/perf/tests/shell/daemon.sh              | 113 ++++++++++++------
 tools/perf/tests/shell/lock_contention.sh     |  70 +++++------
 .../shell/record+probe_libc_inet_pton.sh      |   6 +-
 .../shell/record+script_probe_vfs_getname.sh  |   4 +-
 tools/perf/tests/shell/stat+csv_output.sh     |   4 +-
 tools/perf/tests/shell/stat+json_output.sh    |   2 +-
 tools/perf/tests/shell/stat+shadow_stat.sh    |   4 +-
 tools/perf/tests/shell/stat_all_metrics.sh    |   6 +-
 .../perf/tests/shell/test_arm_callgraph_fp.sh |   6 +-
 tools/perf/tests/shell/test_arm_coresight.sh  |   6 +-
 tools/perf/tests/shell/test_arm_spe.sh        |   2 +-
 tools/perf/tests/shell/test_brstack.sh        |  12 +-
 tools/perf/tests/shell/test_task_analyzer.sh  |  98 ++++++++-------
 .../tests/shell/trace+probe_vfs_getname.sh    |   6 +-
 16 files changed, 203 insertions(+), 149 deletions(-)
Signature · 1 line
2.39.1