Skip to content

Sacrifice your first born to the linter

Randolph Sapp yocto-meta-arago 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest16 patches 3 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/16oe-layertool-setup: split logic and/or expressionsoe-layertool-setup.sh+2 -20 replies
2/16oe-layertool-setup: prefer use of $() notationoe-layertool-setup.sh+40 -400 replies
3/16oe-layertool-setup: replace all x comparisons with -n/-zoe-layertool-setup.sh+27 -270 replies
4/16oe-layertool-setup: fix all the printf callsoe-layertool-setup.sh+10 -100 replies
5/16oe-layertool-setup: fix all quoting, switch eval to exportoe-layertool-setup.sh+111 -1110 replies
6/16oe-layertool-setup: only invoke read with -roe-layertool-setup.sh+9 -90 replies
7/16oe-layertool-setup: check exit code directlyoe-layertool-setup.sh+9 -200 replies
8/16oe-layertool-setup: guard all cd callsoe-layertool-setup.sh+12 -130 replies
9/16oe-layertool-setup: eliminate useless catoe-layertool-setup.sh+1 -10 replies
10/16oe-layertool-setup: use subshell execution with redirectoe-layertool-setup.sh+12 -100 replies
11/16oe-layertool-setup: guard against invalid expression in caseoe-layertool-setup.sh+1 -10 replies
12/16oe-layertool-setup: replace all calls to echo with printfoe-layertool-setup.sh+69 -680 replies
13/16oe-layertool-setup: drop unused variableoe-layertool-setup.sh+0 -10 replies
14/16oe-layertool-setup: add a path sanity check for oebaseoe-layertool-setup.sh+8 -00 replies
15/16oe-layertool-setup: fix multi-line printfsoe-layertool-setup.sh+20 -200 replies
16/16oe-layertool-setup: add sanity check for layer namesoe-layertool-setup.sh+7 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [oe-layersetup][PATCHv2 00/16] Sacrifice your first born to the linter

A few days ago someone in the beagle community reported some cryptic errors from oe-layersetup so I took the time to address all of the issues reported by Shellcheck and add some extra sanity checks.

I tried to split it into reasonable segments.

Resubmitting with a sane email I guess. Probably good I had to resubmit it. Apparently somewhere along the way a patch was dropped in the first series.

Randolph Sapp (16):
oe-layertool-setup: split logic and/or expressions
oe-layertool-setup: prefer use of $() notation
oe-layertool-setup: replace all x comparisons with -n/-z
oe-layertool-setup: fix all the printf calls
oe-layertool-setup: fix all quoting, switch eval to export
oe-layertool-setup: only invoke read with -r
oe-layertool-setup: check exit code directly
oe-layertool-setup: guard all cd calls
oe-layertool-setup: eliminate useless cat
oe-layertool-setup: use subshell execution with redirect
oe-layertool-setup: guard against invalid expression in case
oe-layertool-setup: replace all calls to echo with printf
oe-layertool-setup: drop unused variable
oe-layertool-setup: add a path sanity check for oebase
oe-layertool-setup: fix multi-line printfs
oe-layertool-setup: add sanity check for layer names

 oe-layertool-setup.sh | 435 +++++++++++++++++++++---------------------
 1 file changed, 220 insertions(+), 215 deletions(-)
Signature · 1 line
2.41.0