Skip to content

gpio: aggregator: Incorporate gpio-delay functionality

Andy Shevchenko linux-gpio lkml 2 versions – Applied

Status from this message: Applied patches 1, 2, 4 and 5. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest5 patches 5 repliesApplied
  2. v24 patches 11 repliesSuperseded

Patches in v3 Applied

#Subject and filesSizeRepliesApplied
1/5gpio: aggregator: Remove CONFIG_OF and of_match_ptr() protectionsdrivers/gpio/gpio-aggregator.c+3 -40 replies
2/5gpio: aggregator: Support delay for setting up individual GPIOsdrivers/gpio/gpio-aggregator.c+31 -00 replies
3/5gpio: aggregator: Prevent collisions between DT and user device IDsdrivers/gpio/gpio-aggregator.c+2 -12 replies
4/5gpio: aggregator: Set up a parser of delay line parametersdrivers/gpio/gpio-aggregator.c+70 -20 replies
5/5gpio: delay: Remove duplicative functionalitydrivers/gpio/Kconfig drivers/gpio/Makefile drivers/gpio/gpio-delay.c+0 -1740 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchGeert UytterhoevenLinus WalleijAlexander Stein
SeriesT-b
1/5R-b R-b
2/5R-b R-b
3/5
4/5R-b R-b
5/5R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v3 thread

Cover letter [PATCH v3 0/5] gpio: aggregator: Incorporate gpio-delay functionality

The newly appeared gpio-delay module enables external signal delay lines that may be connected to the GPIOs. But at the same time it copies the GPIO forwarder functionality. Besides that the approach does not scale. If we would have another external component, we would need yet another driver. That's why I think, and seems others support me, better to enable such a functionality inside GPIO aggregator driver.

Patch 1 is a cleanup that may be applied independently on the decision about the rest.

Please, test and comment! Alexander, I would appreciate your tag.

In v3:
- added new patch 3 to prevent device removal from sysfs
- switched to feature in driver data instead of "compatible" (Geert)
- applied tags (Geert, Linus)
- left DT bindings untouched, can be amended later on

In v2:
- split as a series
- covered CONFIG_OF_GPIO=n case
- removed the gpio-delay
- moved gpio-delay Kconfig help to the comment in the code
- left udelay() call untouched as recommended by documentation

Andy Shevchenko (5):
gpio: aggregator: Remove CONFIG_OF and of_match_ptr() protections
gpio: aggregator: Support delay for setting up individual GPIOs
gpio: aggregator: Prevent collisions between DT and user device IDs
gpio: aggregator: Set up a parser of delay line parameters
gpio: delay: Remove duplicative functionality

 drivers/gpio/Kconfig           |   9 --
 drivers/gpio/Makefile          |   1 -
 drivers/gpio/gpio-aggregator.c | 113 +++++++++++++++++++++--
 drivers/gpio/gpio-delay.c      | 164 ---------------------------------
 4 files changed, 106 insertions(+), 181 deletions(-)
 delete mode 100644 drivers/gpio/gpio-delay.c
Signature · 1 line
2.40.0.1.gaa8946217a0b