xfs: fix xfs_extent_busy_flush() deadlock in EFI processing
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 25 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | xfs: pass alloc flags through to xfs_extent_busy_flush()fs/ fs/ fs/ +1 more | +56 | 20 replies | |
| 2/3 | xfs: allow extent free intents to be retriedfs/ | +61 | 4 replies | |
| 3/3 | xfs: don't block in busy flushing when freeing extentsfs/ fs/ fs/ +1 more | +89 | 1 reply |
Reviews trailers per patch
2 of 3 patches have a Reviewed-by or Acked-by.
| Patch | Darrick J. Wong |
|---|---|
| 1/3 | R-b |
| 2/3 | |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] xfs: fix xfs_extent_busy_flush() deadlock in EFI processing
Hi folks,
This patchset is largely a rework of the patch that Wengang posted here:
https://lore.kernel.org/linux-xfs/[email protected]/
Review has run aground because I simply don't have the time to explain every deep, subtle corner case on every issue that is raised before progress can be made fixing this issue. Indeed, this is the second attempt to get this bug fixed that has run aground like this.
Hence I've decided that it's less time and effort to just take what we have, split it, clean it up, fixed it up, remove all the unnecessary bits and run it through testing and push it back out for further review.
I split the alloc flags out as a separate variable that is passed down the stack; I renamed them all "alloc_flags" so that it's clear that the flags being used and passed between the functions are the XFS_ALLOC_FLAG* flag values. If we want to, it will now be trivial to pull these back into the struct xfs_alloc_arg if we so desire - there is no mix-and-match of args->flags and function paramter flags to confuse the issue as was in the original patch.
The changes to xfs_extent_busy_flush() mean that it can now return -EFSCORRUPTED or -EIO from xfs_log_force(), not just -EAGAIN to indicate the transaction must be committed before the allocation is retried. This has been exercised by recoveryloop testing and it appears that the new corruption/error detection conditions do not introduce any new failures.
Cheers,
Dave.