crypto: qat - add heartbeat feature
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest5 patches 1 replyIn review
- v35 patches 5 repliesSuperseded
- v25 patches 1 replySuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 4 patches | 1 reply | Superseded |
Changes in v4 from the cover letter
- improved comment in measure_clock() as suggested by Andy Shevchenko
- changed release date and version for 6.6 in interface documentation
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | crypto: qat - add internal timer for qat 4xxxdrivers/ drivers/ drivers/ +7 more | +137 | 0 replies | |
| 2/5 | crypto: qat - drop obsolete heartbeat interfacedrivers/ | +0 | 0 replies | |
| 3/5 | crypto: qat - add measure clock frequencydrivers/ drivers/ drivers/ +13 more | +268 | 0 replies | |
| 4/5 | crypto: qat - add heartbeat featureDocumentation/ drivers/ drivers/ +18 more | +662 | 0 replies | |
| 5/5 | crypto: qat - add heartbeat counters checkdrivers/ drivers/ drivers/ +3 more | +81 | 0 replies |
Reviews trailers per patch
All 5 patches have a Reviewed-by or Acked-by.
| Patch | Giovanni Cabiddu | Andy Shevchenko |
|---|---|---|
| 1/5 | R-b | R-b |
| 2/5 | R-b | R-b |
| 3/5 | R-b | R-b |
| 4/5 | R-b | R-b |
| 5/5 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/5] crypto: qat - add heartbeat feature
This set introduces support for the QAT heartbeat feature. It allows detection whenever device firmware or acceleration unit will hang. We're adding this feature to allow our clients having a tool with they could verify if all of the Quick Assist hardware resources are healthy and operational.
QAT device firmware periodically writes counters to a specified physical memory location. A pair of counters per thread is incremented at the start and end of the main processing loop within the firmware. Checking for Heartbeat consists of checking the validity of the pair of counter values for each thread. Stagnant counters indicate a firmware hang.
The first patch adds timestamp synchronization to the firmware. The second patch removes historical and never used HB definitions. Patch no. 3 is implementing the hardware clock frequency measuring interface.
The fourth introduces the main heartbeat implementation with the debugfs interface.
The last patch implements an algorithm that allows the code to detect which version of heartbeat API is used at the currently loaded firmware.
Changes since v3:
- improved comment in measure_clock() as suggested by Andy Shevchenko
- changed release date and version for 6.6 in interface documentation
Changes since v2:
- fixed build error on a few of architectures - reduced unnecessary 64bit division.
Changes since v1:
- fixed build errors on a few of architectures - replaced macro DIV_ROUND_CLOSEST with DIV_ROUND_CLOSEST_ULL
- included prerequisite patch "add internal timer for qat 4xxx" which initially was sent separately as this patchset was still in development.
- timer patch reworked to use delayed work as suggested by Herbert Xu
Damian Muszynski (5):
crypto: qat - add internal timer for qat 4xxx
crypto: qat - drop obsolete heartbeat interface
crypto: qat - add measure clock frequency
crypto: qat - add heartbeat feature
crypto: qat - add heartbeat counters check
Documentation/ABI/testing/debugfs-driver-qat | 51 +++ .../intel/qat/qat_4xxx/adf_4xxx_hw_data.c | 14 + .../intel/qat/qat_4xxx/adf_4xxx_hw_data.h | 4 + drivers/crypto/intel/qat/qat_4xxx/adf_drv.c | 3 + .../intel/qat/qat_c3xxx/adf_c3xxx_hw_data.c | 28 ++ .../intel/qat/qat_c3xxx/adf_c3xxx_hw_data.h | 7 + .../intel/qat/qat_c62x/adf_c62x_hw_data.c | 28 ++ .../intel/qat/qat_c62x/adf_c62x_hw_data.h | 7 + drivers/crypto/intel/qat/qat_common/Makefile | 4 + .../intel/qat/qat_common/adf_accel_devices.h | 13 + .../crypto/intel/qat/qat_common/adf_admin.c | 43 +++ .../intel/qat/qat_common/adf_cfg_strings.h | 2 + .../crypto/intel/qat/qat_common/adf_clock.c | 131 +++++++ .../crypto/intel/qat/qat_common/adf_clock.h | 14 + .../intel/qat/qat_common/adf_common_drv.h | 5 + .../crypto/intel/qat/qat_common/adf_dbgfs.c | 9 +- .../intel/qat/qat_common/adf_gen2_config.c | 7 + .../intel/qat/qat_common/adf_gen2_hw_data.h | 3 + .../intel/qat/qat_common/adf_gen4_hw_data.h | 3 + .../intel/qat/qat_common/adf_gen4_timer.c | 70 ++++ .../intel/qat/qat_common/adf_gen4_timer.h | 21 ++ .../intel/qat/qat_common/adf_heartbeat.c | 336 ++++++++++++++++++ .../intel/qat/qat_common/adf_heartbeat.h | 79 ++++ .../qat/qat_common/adf_heartbeat_dbgfs.c | 194 ++++++++++ .../qat/qat_common/adf_heartbeat_dbgfs.h | 12 + .../crypto/intel/qat/qat_common/adf_init.c | 28 ++ drivers/crypto/intel/qat/qat_common/adf_isr.c | 6 + .../qat/qat_common/icp_qat_fw_init_admin.h | 23 +- .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.c | 13 + .../qat/qat_dh895xcc/adf_dh895xcc_hw_data.h | 5 + 30 files changed, 1147 insertions(+), 16 deletions(-) create mode 100644 drivers/crypto/intel/qat/qat_common/adf_clock.c create mode 100644 drivers/crypto/intel/qat/qat_common/adf_clock.h create mode 100644 drivers/crypto/intel/qat/qat_common/adf_gen4_timer.c create mode 100644 drivers/crypto/intel/qat/qat_common/adf_gen4_timer.h create mode 100644 drivers/crypto/intel/qat/qat_common/adf_heartbeat.c create mode 100644 drivers/crypto/intel/qat/qat_common/adf_heartbeat.h create mode 100644 drivers/crypto/intel/qat/qat_common/adf_heartbeat_dbgfs.c create mode 100644 drivers/crypto/intel/qat/qat_common/adf_heartbeat_dbgfs.h
base-commit: 67b9bc0df80cfa241fe7a9c2b857c3e3efde982a
Signature · 1 line
2.40.1