Introduce SMT level and add PowerPC support
Status from this message: The following commit has been merged into the smp/core branch of tip:
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest10 patches 13 repliesApplied
- v39 patches 9 repliesSuperseded
- v29 patches 4 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 10 patches | 3 replies | Superseded |
Changes in v4 from the cover letter
Rebase on top of 6.5's updates
Remove a dependancy against the X86's symbol cpu_primary_thread_mask
Patches in v4 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/10 | cpu/hotplug: remove dependancy against cpu_primary_thread_maskkernel/ | +10 | 0 replies | |
| 2/10 | cpu/SMT: Move SMT prototypes into cpu_smt.harch/ include/ include/ +1 more | +33 | 0 replies | |
| 3/10 | cpu/SMT: Move smt/control simple exit cases earlierkernel/ | +6 | 0 replies | |
| 4/10 | cpu/SMT: Store the current/max number of threadsarch/ include/ kernel/ | +27 | 0 replies | |
| 5/10 | cpu/SMT: Remove topology_smt_supported()arch/ arch/ kernel/ | +2 | 0 replies | |
| 6/10 | cpu/SMT: Create topology_smt_thread_allowed()arch/ kernel/ | +26 | 0 replies | |
| 7/10 | cpu/SMT: Allow enabling partial SMT states via sysfsDocumentation/ kernel/ | +45 | 1 reply | |
| 8/10 | powerpc/pseries: Initialise CPU hotplug callbacks earlierarch/ arch/ arch/ | +17 | 1 reply | |
| 9/10 | powerpc: Add HOTPLUG_SMT supportDocumentation/ arch/ arch/ +1 more | +26 | 1 reply | |
| 10/10 | powerpc/pseries: Honour current SMT state when DLPAR onlining CPUsarch/ | +8 | 1 reply |
Reviews trailers per patch
3 of 10 patches have a Reviewed-by or Acked-by.
| Patch | Zhang Rui | Xi Ruoyao | Jeff Chua | Srikar Dronamraju |
|---|---|---|---|---|
| Series | T-b Reported-and-tested-by | T-b | Reported-and-tested-by | |
| 1/10 | ||||
| 2/10 | ||||
| 3/10 | ||||
| 4/10 | ||||
| 5/10 | ||||
| 6/10 | ||||
| 7/10 | ||||
| 8/10 | R-b | |||
| 9/10 | R-b | |||
| 10/10 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v4 00/10] Introduce SMT level and add PowerPC support
I'm taking over the series Michael sent previously [1] which is smartly reviewing the initial series I sent [2]. This series is addressing the comments sent by Thomas and me on the Michael's one.
Here is a short introduction to the issue this series is addressing:
When a new CPU is added, the kernel is activating all its threads. This leads to weird, but functional, result when adding CPU on a SMT 4 system for instance.
Here the newly added CPU 1 has 8 threads while the other one has 4 threads active (system has been booted with the 'smt-enabled=4' kernel option):
ltcden3-lp12:~ # ppc64_cpu --info
Core 0: 0* 1* 2* 3* 4 5 6 7 Core 1: 8* 9* 10* 11* 12* 13* 14* 15*
This mixed SMT level may confused end users and/or some applications.
There is no SMT level recorded in the kernel (common code), neither in user space, as far as I know. Such a level is helpful when adding new CPU or when optimizing the energy efficiency (when reactivating CPUs).
When SMP and HOTPLUG_SMT are defined, this series is adding a new SMT level (cpu_smt_num_threads) and few callbacks allowing the architecture code to fine control this value, setting a max and a "at boot" level, and controling whether a thread should be onlined or not.
v4:
Rebase on top of 6.5's updates
Remove a dependancy against the X86's symbol cpu_primary_thread_mask
v3:
Fix a build error in the patch 6/9
v2:
As Thomas suggested,
Reword some commit's description
Remove topology_smt_supported()
Remove topology_smt_threads_supported()
Introduce CONFIG_SMT_NUM_THREADS_DYNAMIC
Remove switch() in __store_smt_control()
Update kernel-parameters.txt
[1] https://lore.kernel.org/linuxppc-dev/[email protected]/
[2] https://lore.kernel.org/linuxppc-dev/[email protected]/
Laurent Dufour (2):
cpu/hotplug: remove dependancy against cpu_primary_thread_mask cpu/SMT: Remove topology_smt_supported()
Michael Ellerman (8):
cpu/SMT: Move SMT prototypes into cpu_smt.h
cpu/SMT: Move smt/control simple exit cases earlier cpu/SMT: Store the current/max number of threads cpu/SMT: Create topology_smt_thread_allowed()
cpu/SMT: Allow enabling partial SMT states via sysfs powerpc/pseries: Initialise CPU hotplug callbacks earlier
powerpc: Add HOTPLUG_SMT support
powerpc/pseries: Honour current SMT state when DLPAR onlining CPUs
.../ABI/testing/sysfs-devices-system-cpu | 1 + .../admin-guide/kernel-parameters.txt | 4 +- arch/Kconfig | 3 + arch/powerpc/Kconfig | 2 + arch/powerpc/include/asm/topology.h | 15 ++ arch/powerpc/kernel/smp.c | 8 +- arch/powerpc/platforms/pseries/hotplug-cpu.c | 30 ++-- arch/powerpc/platforms/pseries/pseries.h | 2 + arch/powerpc/platforms/pseries/setup.c | 2 + arch/x86/include/asm/topology.h | 4 +- arch/x86/kernel/cpu/common.c | 2 +- arch/x86/kernel/smpboot.c | 8 - include/linux/cpu.h | 25 +-- include/linux/cpu_smt.h | 33 ++++ kernel/cpu.c | 142 +++++++++++++----- 15 files changed, 196 insertions(+), 85 deletions(-) create mode 100644 include/linux/cpu_smt.h
Signature · 1 line
2.41.0