Skip to content

wifi: rtw88: correct AP and PS mode behaviors

Ping-Ke Shih linux-wireless 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest6 patches 2 repliesIn review
  2. v16 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- fix patch 1/6 problems
* correct to use RTW_TX_DESC_W7_DMA_TXAGG_NUM to set agg_num
* use correct le32p_replace_bits() to set value instead

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6wifi: rtw88: use struct instead of macros to set TX descdrivers/net/wireless/realtek/rtw88/rtw8723d.c drivers/net/wireless/realtek/rtw88/tx.c drivers/net/wireless/realtek/rtw88/tx.h +1 more+106 -1131 reply
2/6wifi: rtw88: Fix AP mode incorrect DTIM behaviordrivers/net/wireless/realtek/rtw88/mac80211.c drivers/net/wireless/realtek/rtw88/reg.h drivers/net/wireless/realtek/rtw88/tx.c +2 more+13 -10 replies
3/6wifi: rtw88: Skip high queue in hci_flushdrivers/net/wireless/realtek/rtw88/pci.c+3 -20 replies
4/6wifi: rtw88: Stop high queue during scandrivers/net/wireless/realtek/rtw88/main.c drivers/net/wireless/realtek/rtw88/reg.h+6 -20 replies
5/6wifi: rtw88: refine register based H2C commanddrivers/net/wireless/realtek/rtw88/fw.c drivers/net/wireless/realtek/rtw88/fw.h+56 -00 replies
6/6wifi: rtw88: fix not entering PS mode after AP stopsdrivers/net/wireless/realtek/rtw88/fw.c drivers/net/wireless/realtek/rtw88/fw.h drivers/net/wireless/realtek/rtw88/mac80211.c +2 more+35 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/6] wifi: rtw88: correct AP and PS mode behaviors

In AP mode, HI queue is used to transmit broadcast/multicast right after issuing beacon, and we need set MORE_DATA in TX description to make hardware transmits all packets in one go. Also, have special deal with this queue when doing scan and flush.

After stopping AP from SCC (AP + STA), only one STA is working, so PS mode is expected to enable. However, firmware checks the MAC port used by AP mode before, and then can't enter PS mode. We add the last patch to set "default port" to the port used by STA. Then, firmware will check correct port to enter PS mode in expectation.

Note: The patch 5/6 ("wifi: rtw88: refine register based H2C command") adds new static function that is used by patch 6/6, so compiler will warn unused function if we build this path.

v2:
- fix patch 1/6 problems
* correct to use RTW_TX_DESC_W7_DMA_TXAGG_NUM to set agg_num
* use correct le32p_replace_bits() to set value instead

Po-Hao Huang (6):
wifi: rtw88: use struct instead of macros to set TX desc
wifi: rtw88: Fix AP mode incorrect DTIM behavior
wifi: rtw88: Skip high queue in hci_flush
wifi: rtw88: Stop high queue during scan
wifi: rtw88: refine register based H2C command
wifi: rtw88: fix not entering PS mode after AP stops

 drivers/net/wireless/realtek/rtw88/fw.c       |  68 ++++++++++
 drivers/net/wireless/realtek/rtw88/fw.h       |  13 ++
 drivers/net/wireless/realtek/rtw88/mac80211.c |   3 +
 drivers/net/wireless/realtek/rtw88/main.c     |  15 ++-
 drivers/net/wireless/realtek/rtw88/main.h     |   1 +
 drivers/net/wireless/realtek/rtw88/pci.c      |   5 +-
 drivers/net/wireless/realtek/rtw88/reg.h      |   2 +
 drivers/net/wireless/realtek/rtw88/rtw8723d.c |   6 +-
 drivers/net/wireless/realtek/rtw88/tx.c       |  84 +++++++-----
 drivers/net/wireless/realtek/rtw88/tx.h       | 123 ++++++++----------
 drivers/net/wireless/realtek/rtw88/usb.c      |  15 ++-
 11 files changed, 218 insertions(+), 117 deletions(-)
Signature · 1 line
2.25.1