Skip to content

Prep patches for porting overlayfs to new mount api

Amir Goldstein linux-unionfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest5 patches 10 repliesIn review
  2. v12 patches 1 replySuperseded

Changes in v2 from the cover letter

- Fix xino opt name table vs. enum order
- Add cleanup patch for xino
- Add cleanup of share_whiteout state
- Add cleanup patch for ovl_get_root()

[1] https://github.com/amir73il/linux/commits/fs-overlayfs-mount_api

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5ovl: negate the ofs->share_whiteout booleanfs/overlayfs/dir.c fs/overlayfs/ovl_entry.h fs/overlayfs/super.c+4 -71 reply
2/5ovl: clarify ovl_get_root() semanticsfs/overlayfs/super.c+3 -11 reply
3/5ovl: pass ovl_fs to xino helpersfs/overlayfs/inode.c fs/overlayfs/overlayfs.h fs/overlayfs/readdir.c +1 more+43 -311 reply
4/5ovl: store enum redirect_mode in config instead of a stringDocumentation/filesystems/overlayfs.rst fs/overlayfs/dir.c fs/overlayfs/namei.c +4 more+107 -893 replies
5/5ovl: factor out ovl_parse_options() helperfs/overlayfs/overlayfs.h fs/overlayfs/super.c+135 -1161 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchChristian Brauner
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/5] Prep patches for porting overlayfs to new mount api

Miklos,

Following some more cleanup patches that make Christian's new mount api patches smaller and easier to review.

I had rebased Christain's patches over these cleanups and pushed the result to github branch fs-overlayfs-mount_api [1].

The v1 prep patches had a bug with xino option parsing that resulted in some tests being skipped (not failing) and I had only noticed the skipped test after posting v1.

The v2 prep patches + new mount api patches have passed all the tests with no new tests skipped.

In addition to running the tests with the default kernel config, I also ran the tests with the following non-default configs (individually):

1) CONFIG_OVERLAY_FS_REDIRECT_DIR=y
2) CONFIG_OVERLAY_FS_REDIRECT_ALWAYS_FOLLOW=n
3) CONFIG_OVERLAY_FS_XINO_AUTO=y

Thanks.
Amir.

Changes since v1:
- Fix xino opt name table vs. enum order
- Add cleanup patch for xino
- Add cleanup of share_whiteout state
- Add cleanup patch for ovl_get_root()

[1] https://github.com/amir73il/linux/commits/fs-overlayfs-mount_api

Amir Goldstein (5):
ovl: negate the ofs->share_whiteout boolean
ovl: clarify ovl_get_root() semantics
ovl: pass ovl_fs to xino helpers
ovl: store enum redirect_mode in config instead of a string
ovl: factor out ovl_parse_options() helper

 Documentation/filesystems/overlayfs.rst |   9 +-
 fs/overlayfs/dir.c                      |   6 +-
 fs/overlayfs/inode.c                    |  18 +-
 fs/overlayfs/namei.c                    |   6 +-
 fs/overlayfs/overlayfs.h                |  63 ++--
 fs/overlayfs/ovl_entry.h                |   8 +-
 fs/overlayfs/readdir.c                  |  19 +-
 fs/overlayfs/super.c                    | 364 +++++++++++++-----------
 fs/overlayfs/util.c                     |   7 -
 9 files changed, 274 insertions(+), 226 deletions(-)
Signature · 1 line
2.34.1