Skip to content

drm/xe/pmu: Enable PMU interface

Aravind Iddamsetty intel-xe 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 posting 2/21 of 2 patches 0 repliesNew
  2. v4 Latest1 of 2 patches 2 repliesIn review
  3. v3 posting 1/22 patches 18 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v22 patches51 repliesSuperseded
v12 patches0 repliesSuperseded

v3 from the cover letter

1. drop init_samples, as storing counters before going to suspend should be sufficient.
2. ported the "drm/i915/pmu: Make PMU sample array two-dimensional" and dropped helpers to store and read samples.
3. use xe_device_mem_access_get_if_ongoing to check if device is active before reading the OA registers.
4. dropped format attr as no longer needed
5. introduce xe_pmu_suspend to call engine_group_busyness_store
6. few other nits.

1 of 2 patches is in this archive. The cover letter announces 2.

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/2drm/xe/pmu: Enable PMU interfacedrivers/gpu/drm/xe/Makefile drivers/gpu/drm/xe/regs/xe_gt_regs.h drivers/gpu/drm/xe/xe_device.c +8 more+830 -02 replies

Reviews trailers per patch

The patch has no Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchTejas UpadhyayAshutosh Dixit
SeriesR-b R-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [Intel-xe] [PATCH v4 0/2] drm/xe/pmu: Enable PMU interface

There are a set of engine group busyness counters provided by HW which are perfect fit to be exposed via PMU perf events.

BSPEC: 46559, 46560, 46722, 46729, 52071, 71028

events can be listed using:
perf list

  xe_0000_03_00.0/any-engine-group-busy-gt0/         [Kernel PMU event]
  xe_0000_03_00.0/copy-group-busy-gt0/               [Kernel PMU event]
  xe_0000_03_00.0/interrupts/                        [Kernel PMU event]
  xe_0000_03_00.0/media-group-busy-gt0/              [Kernel PMU event]
  xe_0000_03_00.0/render-group-busy-gt0/             [Kernel PMU event]

and can be read using:

perf stat -e "xe_0000_8c_00.0/render-group-busy-gt0/" -I 1000

           time             counts unit events
     1.001139062                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     2.003294678                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     3.005199582                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     4.007076497                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     5.008553068                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     6.010531563              43520 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     7.012468029              44800 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     8.013463515                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
     9.015300183                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
    10.017233010                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/
    10.971934120                  0 ns  xe_0000_8c_00.0/render-group-busy-gt0/

The pmu base implementation is taken from i915.

v4: Minor nits.

v3:
1. drop init_samples, as storing counters before going to suspend should be sufficient.
2. ported the "drm/i915/pmu: Make PMU sample array two-dimensional" and dropped helpers to store and read samples.
3. use xe_device_mem_access_get_if_ongoing to check if device is active before reading the OA registers.
4. dropped format attr as no longer needed
5. introduce xe_pmu_suspend to call engine_group_busyness_store
6. few other nits.

v2:
Store last known value when device is awake return that while the GT is suspended and then update the driver copy when read during awake.

Aravind Iddamsetty (2):
drm/xe: Get GT clock to nanosecs
drm/xe/pmu: Enable PMU interface

 drivers/gpu/drm/xe/Makefile          |   2 +
 drivers/gpu/drm/xe/regs/xe_gt_regs.h |   5 +
 drivers/gpu/drm/xe/xe_device.c       |   2 +
 drivers/gpu/drm/xe/xe_device_types.h |   4 +
 drivers/gpu/drm/xe/xe_gt.c           |   2 +
 drivers/gpu/drm/xe/xe_gt_clock.c     |   5 +
 drivers/gpu/drm/xe/xe_gt_clock.h     |   4 +-
 drivers/gpu/drm/xe/xe_irq.c          |  18 +
 drivers/gpu/drm/xe/xe_module.c       |   5 +
 drivers/gpu/drm/xe/xe_pmu.c          | 675 +++++++++++++++++++++++++++
 drivers/gpu/drm/xe/xe_pmu.h          |  25 +
 drivers/gpu/drm/xe/xe_pmu_types.h    |  76 +++
 include/uapi/drm/xe_drm.h            |  16 +
 13 files changed, 838 insertions(+), 1 deletion(-)
 create mode 100644 drivers/gpu/drm/xe/xe_pmu.c
 create mode 100644 drivers/gpu/drm/xe/xe_pmu.h
 create mode 100644 drivers/gpu/drm/xe/xe_pmu_types.h
Signature · 1 line
2.25.1