Skip to content

Various dist-related fixes

Frank Lichtenheld openvpn-devel 1 version In review

Get series with b4
b4 am [email protected]...

Versions newest first

  1. v1 Latest4 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4dist: add more missing files only used in the MSVC buildbuild/msvc/msvc-generate/Makefile.am src/openvpn/Makefile.am+3 -11 reply
2/4vcpkg-ports/pkcs11-helper: rename patches to make file names shortercontrib/vcpkg-ports/pkcs11-helper/Fix-build-with-disable-shared.patch contrib/vcpkg-ports/pkcs11-helper/config-w32-vc.h.in-indicate-OpenSSL.patch contrib/vcpkg-ports/pkcs11-helper/nmake-compatibility-with-vcpkg-nmake.patch +1 more+3 -32 replies
3/4unit_tests: Add missing cert_data.h to source list for unit teststests/unit_tests/openvpn/Makefile.am+2 -21 reply
4/4dist: Include all documentation in distributionMakefile.am doc/Makefile.am doc/doxygen/Makefile.am+32 -31 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchGert Doering
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Openvpn-devel] [PATCH 0/4] Various dist-related fixes

After this series the diff between git and the tarball is:

Only in ../: dev-tools
Only in openvpn-2.7_git/doc: openvpn.8
Only in openvpn-2.7_git/doc: openvpn.8.html Only in openvpn-2.7_git/doc: openvpn-examples.5 Only in openvpn-2.7_git/doc: openvpn-examples.5.html Only in ../: .git
Only in ../: .git-blame-ignore-revs
Only in ../: .github
Only in openvpn-2.7_git/include: openvpn-plugin.h Only in ../m4: .keep
Only in ../: .mailmap
Only in openvpn-2.7_git/sample/sample-plugins: Makefile Only in ../: .svncommitters
Only in ../: .travis
Only in ../: .travis.yml

That looks reasonable to me.

Frank Lichtenheld (4):
dist: add more missing files only used in the MSVC build vcpkg-ports/pkcs11-helper: rename patches to make file names shorter
unit_tests: Add missing cert_data.h to source list for unit tests
dist: Include all documentation in distribution

 Makefile.am                                   |  5 ++++-
 build/msvc/msvc-generate/Makefile.am          |  1 +
 ...ch => Fix-build-with-disable-shared.patch} |  0
 ...config-w32-vc.h.in-indicate-OpenSSL.patch} |  0
 ...make-compatibility-with-vcpkg-nmake.patch} |  0
 .../vcpkg-ports/pkcs11-helper/portfile.cmake  |  6 +++---
 doc/Makefile.am                               |  9 +++++++-
 doc/doxygen/Makefile.am                       | 21 ++++++++++++++++++-
 src/openvpn/Makefile.am                       |  3 ++-
 tests/unit_tests/openvpn/Makefile.am          |  4 ++--
 10 files changed, 40 insertions(+), 9 deletions(-)
 rename contrib/vcpkg-ports/pkcs11-helper/{0001-Allow-the-build-to-succeed-if-configured-with-disabl.patch => Fix-build-with-disable-shared.patch} (100%)
 rename contrib/vcpkg-ports/pkcs11-helper/{0002-config-w32-vc.h.in-indicate-OpenSSL.patch => config-w32-vc.h.in-indicate-OpenSSL.patch} (100%)
 rename contrib/vcpkg-ports/pkcs11-helper/{0001-nmake-compatibility-with-vcpkg-nmake.patch => nmake-compatibility-with-vcpkg-nmake.patch} (100%)
Signature · 1 line
2.34.1