Skip to content

ASoC: remove copy of intlog10()

Andy Shevchenko alsa-devel linux-doc linux-media lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 2 repliesIn review
  2. v14 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- moved kernel doc inclusion to the generic place (Mauro)
- added tags (Mauro, Mark)

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4lib/math: Move dvb_math.c into lib/math/int_log.cDocumentation/core-api/kernel-api.rst Documentation/driver-api/media/dtv-common.rst drivers/media/dvb-core/Makefile +29 more+42 -481 reply
2/4lib/math/int_log: Use ARRAY_SIZE(logtable) where makes senselib/math/int_log.c+2 -20 replies
3/4lib/math/int_log: Replace LGPL-2.1-or-later boilerplate with SPDX identifierinclude/linux/int_log.h lib/math/int_log.c+2 -200 replies
4/4ASoC: nau8825: Replace copied'n'pasted intlog10()sound/soc/codecs/nau8825.c+3 -900 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchMauro Carvalho ChehabMark BrownRandy Dunlap
1/4R-b A-b R-b
2/4R-b A-b
3/4A-b
4/4A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/4] ASoC: remove copy of intlog10()

The first three patches moves intlog10() to be available in entire kernel. The last one removes copy of it in one driver. Besides already good Lines of Code (LoC) statistics the upcoming users, if any, can utilize the exported functions.

The series can be routed via ASoC tree (as Mauro suggested).

Note, int_log.h is separated from math.h due to licensing. I dunno if we can mix two in a single header file. In any case we may do it later on.

Changelog v2:
- moved kernel doc inclusion to the generic place (Mauro)
- added tags (Mauro, Mark)

Andy Shevchenko (4):
lib/math: Move dvb_math.c into lib/math/int_log.c lib/math/int_log: Use ARRAY_SIZE(logtable) where makes sense lib/math/int_log: Replace LGPL-2.1-or-later boilerplate with SPDX
identifier
ASoC: nau8825: Replace copied'n'pasted intlog10()

 Documentation/core-api/kernel-api.rst         |  7 +-
 Documentation/driver-api/media/dtv-common.rst |  9 --
 drivers/media/dvb-core/Makefile               |  2 +-
 drivers/media/dvb-frontends/af9013_priv.h     |  2 +-
 drivers/media/dvb-frontends/af9033_priv.h     |  2 +-
 drivers/media/dvb-frontends/cxd2820r_priv.h   |  2 +-
 drivers/media/dvb-frontends/cxd2841er.c       |  2 +-
 .../cxd2880/cxd2880_tnrdmd_dvbt2_mon.c        |  2 +-
 .../cxd2880/cxd2880_tnrdmd_dvbt_mon.c         |  2 +-
 .../media/dvb-frontends/cxd2880/cxd2880_top.c |  2 +-
 drivers/media/dvb-frontends/dib7000p.c        |  2 +-
 drivers/media/dvb-frontends/dib8000.c         |  2 +-
 drivers/media/dvb-frontends/dib9000.c         |  2 +-
 drivers/media/dvb-frontends/drxk_hard.c       |  2 +-
 drivers/media/dvb-frontends/lgdt3305.c        |  2 +-
 drivers/media/dvb-frontends/lgdt3306a.c       |  2 +-
 drivers/media/dvb-frontends/lgdt330x.c        |  2 +-
 drivers/media/dvb-frontends/m88ds3103_priv.h  |  2 +-
 drivers/media/dvb-frontends/mn88443x.c        |  2 +-
 drivers/media/dvb-frontends/mn88472_priv.h    |  2 +-
 drivers/media/dvb-frontends/mn88473_priv.h    |  2 +-
 drivers/media/dvb-frontends/or51132.c         |  2 +-
 drivers/media/dvb-frontends/or51211.c         |  2 +-
 drivers/media/dvb-frontends/rtl2830_priv.h    |  2 +-
 drivers/media/dvb-frontends/rtl2832_priv.h    |  2 +-
 drivers/media/dvb-frontends/si2165.c          |  2 +-
 drivers/media/dvb-frontends/stv0367.c         |  2 +-
 drivers/media/dvb-frontends/tc90522.c         |  2 +-
 drivers/media/dvb-frontends/tda10048.c        |  2 +-
 include/{media/dvb_math.h => linux/int_log.h} | 18 +---
 lib/math/Makefile                             |  2 +-
 .../dvb-core/dvb_math.c => lib/math/int_log.c | 26 ++----
 sound/soc/codecs/nau8825.c                    | 93 +------------------
 33 files changed, 49 insertions(+), 160 deletions(-)
 rename include/{media/dvb_math.h => linux/int_log.h} (63%)
 rename drivers/media/dvb-core/dvb_math.c => lib/math/int_log.c (84%)
Signature · 1 line
2.40.0.1.gaa8946217a0b