Skip to content

RDMA/rxe: Fix error path code in rxe_create_qp

Bob Pearson linux-rdma 2 versions – Applied

Status from this message: Applied to for-next, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 4 repliesApplied
  2. v13 patches 2 repliesSuperseded

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/3RDMA/rxe: Move work queue code to subroutinesdrivers/infiniband/sw/rxe/rxe_qp.c+108 -553 replies
2/3RDMA/rxe: Fix unsafe drain work queue codedrivers/infiniband/sw/rxe/rxe_comp.c drivers/infiniband/sw/rxe/rxe_resp.c+8 -00 replies
3/3RDMA/rxe: Fix rxe_modify_srqdrivers/infiniband/sw/rxe/rxe_loc.h drivers/infiniband/sw/rxe/rxe_srq.c+36 -300 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchZhu Yanjun
1/3A-b
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH for-next v2 0/3] RDMA/rxe: Fix error path code in rxe_create_qp

If a call to rxe_create_qp() fails in rxe_qp_from_init() rxe_cleanup(qp) will be called. This code currently does not correctly handle cases where not all qp resources are allocated and can seg fault as reported below. The first two patches cleanup cases where this happens. The third patch corrects an error in rxe_srq.c where if caller requests a change in the srq size the correct new value is not returned to caller.

This patch series applies cleanly to the current for-next branch.

Reported-by [email protected]
Fixes 49dc9c1f0c7e ("RDMA/rxe: Cleanup reset state handling in rxe_resp.c")
Fixes fbdeb828a21f ("RDMA/rxe: Cleanup error state handling in rxe_comp.c")

---
v2: Reverted a partially implemented change in patch 3/3 which was
incorrect.

Bob Pearson (3):
RDMA/rxe: Move work queue code to subroutines
RDMA/rxe: Fix unsafe drain work queue code
RDMA/rxe: Fix rxe_m-dify_srq

 drivers/infiniband/sw/rxe/rxe_comp.c |   4 +
 drivers/infiniband/sw/rxe/rxe_loc.h  |   6 -
 drivers/infiniband/sw/rxe/rxe_qp.c   | 163 ++++++++++++++++++---------
 drivers/infiniband/sw/rxe/rxe_resp.c |   4 +
 drivers/infiniband/sw/rxe/rxe_srq.c  |  60 ++++++----
 5 files changed, 152 insertions(+), 85 deletions(-)

base-commit: 830f93f47068b1632cc127871fbf27e918efdf46

Signature · 1 line
2.39.2