Skip to content

platform/x86: asus-wmi:

Luke D. Jones linux-hwmon lkml oe-kbuild-all platform-driver-x86 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 9 repliesIn review
  2. v18 patches 0 repliesSuperseded

Changelog from the cover letter

- v2-0008-platform-x86-asus-wmi-expose-dGPU-and-CPU-tunable.patch
- Rename the WMI defs to match what ASUS supplied as names
- Remove EDC and TDC exposure (unsafe)
- Slight change to formatting
- Add better notes to documentation

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8platform/x86: asus-wmi: add support for showing charger modeDocumentation/ABI/testing/sysfs-platform-asus-wmi drivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+34 -01 reply
2/8platform/x86: asus-wmi: add support for showing middle fan RPMdrivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+92 -01 reply
3/8platform/x86: asus-wmi: support middle fan custom curvesdrivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+76 -21 reply
4/8platform/x86: asus-wmi: add WMI method to show if egpu connectedDocumentation/ABI/testing/sysfs-platform-asus-wmi drivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+34 -21 reply
5/8platform/x86: asus-wmi: don't allow eGPU switching if eGPU not connecteddrivers/platform/x86/asus-wmi.c+9 -01 reply
6/8platform/x86: asus-wmi: add safety checks to gpu switchingdrivers/platform/x86/asus-wmi.c+49 -11 reply
7/8platform/x86: asus-wmi: support setting mini-LED modeDocumentation/ABI/testing/sysfs-platform-asus-wmi drivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+63 -01 reply
8/8platform/x86: asus-wmi: expose dGPU and CPU tunables for ROGDocumentation/ABI/testing/sysfs-platform-asus-wmi drivers/platform/x86/asus-wmi.c include/linux/platform_data/x86/asus-wmi.h+352 -01 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchHans de Goede
1/8R-b
2/8R-b
3/8R-b
4/8R-b
5/8R-b
6/8R-b
7/8R-b
8/8R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/8] platform/x86: asus-wmi:

This patch series adds or exposes more features that are available in the ROG laptop series.

- expose dGPU and CPU tunables for ROG
- These are things like GPU boost, CPU Pl1 and PL2, package power limits
- support setting mini-LED mode
- Some newer laptops have a screen that can toggle between regular style backlight and using mini-LED backlight
- add WMI method to show if egpu connected
- This WMI method can be monitored/queried to see if it is possible to begin the change-over to eGPU
- support middle fan custom curves
- Some newer laptops have a center/middle fan which blows across the CPU and GPU
- add support for showing middle fan RPM
- add support for showing charger mode (AC, USB-C, both plugged)
- add additional checks to GPU switching code
- These try to prevent a sceanrio such as the user disabling the dGPU while it is driving the internal panel via MUX, resulting in no output at all. There are no checks in the ACPI code for this, but on some newer models ASUS did finally add a switch in the BIOS menu. It is best to try and prevent this at the kernel level rather than userland level.

All patches pass ./scripts/checkpatch.pl

Changelog:
- v2-0008-platform-x86-asus-wmi-expose-dGPU-and-CPU-tunable.patch
- Rename the WMI defs to match what ASUS supplied as names
- Remove EDC and TDC exposure (unsafe)
- Slight change to formatting
- Add better notes to documentation

Luke D. Jones (8):
platform/x86: asus-wmi: add support for showing charger mode platform/x86: asus-wmi: add support for showing middle fan RPM platform/x86: asus-wmi: support middle fan custom curves platform/x86: asus-wmi: add WMI method to show if egpu connected platform/x86: asus-wmi: don't allow eGPU switching if eGPU not
connected
platform/x86: asus-wmi: add safety checks to gpu switching platform/x86: asus-wmi: support setting mini-LED mode platform/x86: asus-wmi: expose dGPU and CPU tunables for ROG

 .../ABI/testing/sysfs-platform-asus-wmi       |  86 +++
 drivers/platform/x86/asus-wmi.c               | 605 +++++++++++++++++-
 include/linux/platform_data/x86/asus-wmi.h    |  19 +-
 3 files changed, 707 insertions(+), 3 deletions(-)
Signature · 1 line
2.41.0