Skip to content

net: dsa: microchip: fix writes to phy registers >= 0x10

Rasmus Villemoes lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesApplied 3/3

Patches in v1 All 3 applied

#Subject and filesSizeRepliesApplied
1/3net: dsa: microchip: simplify ksz_prmw8()drivers/net/dsa/microchip/ksz_common.h+2 -112 repliesApplied
2/3net: dsa: microchip: add ksz_prmw32() helperdrivers/net/dsa/microchip/ksz_common.h+7 -02 repliesApplied
3/3net: dsa: microchip: fix writes to phy registers >= 0x10drivers/net/dsa/microchip/ksz9477.c+17 -13 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchSimon HormanAndrew LunnArun Ramadoss
1/3R-b A-b
2/3R-b A-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH net-next 0/3] net: dsa: microchip: fix writes to phy registers >= 0x10

Patch 1 is just a simplification, technically unrelated to the other two patches. But it would be a bit inconsistent to have the new ksz_prmw32() introduced in patch 2 use ksz_rmw32() while leaving ksz_prmw8() as-is.

The actual fix is of course patch 3. I can definitely see some weird behaviour on our ksz9567 when writing to phy registers 0x1e and 0x1f (with phytool from userspace), though it does not seem that the effect is always to write zeroes to the buddy register as the errata sheet says would be the case. In our case, the switch is connected via i2c; I hope somebody with other switches and/or the SPI variants can test this.

Rasmus Villemoes (3):
net: dsa: microchip: simplify ksz_prmw8()
net: dsa: microchip: add ksz_prmw32() helper
net: dsa: microchip: fix writes to phy registers >= 0x10

 drivers/net/dsa/microchip/ksz9477.c    | 18 +++++++++++++++++-
 drivers/net/dsa/microchip/ksz_common.h | 18 ++++++++----------
 2 files changed, 25 insertions(+), 11 deletions(-)
Signature · 1 line
2.37.2