virtio-mem: Support "x-ignore-shared" migration
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest4 patches 22 repliesIn review
- v14 patches 10 repliesSuperseded
Changes in v2 from the cover letter
- Pick up tags
- "virtio-mem: Support "x-ignore-shared" migration" -> Fix spelling mistake
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | softmmu/physmem: Warn with ram_block_discard_range() on MAP_PRIVATE file mappingsoftmmu/ | +18 | 13 replies | |
| 2/4 | virtio-mem: Skip most of virtio_mem_unplug_all() without plugged memoryhw/ | +10 | 3 replies | |
| 3/4 | migration/ram: Expose ramblock_is_ignored() as migrate_ram_is_ignored()include/ migration/ migration/ +1 more | +10 | 1 reply | |
| 4/4 | virtio-mem: Support "x-ignore-shared" migrationhw/ | +38 | 3 replies |
Reviews trailers per patch
All 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Peter Xu | Mario Casquero | Juan Quintela | Michael S. Tsirkin |
|---|---|---|---|---|
| Series | R-b | |||
| 1/4 | A-b | T-b | R-b | |
| 2/4 | T-b | R-b | ||
| 3/4 | A-b | T-b | R-b | |
| 4/4 | T-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v2 0/4] virtio-mem: Support "x-ignore-shared" migration
If there is no further feedback, I'll queue this myself shortly.
Stumbling over "x-ignore-shared" migration support for virtio-mem on my todo list, I remember talking to Dave G. a while ago about how ram_block_discard_range() in MAP_PIRVATE file mappings is possibly harmful when the file is used somewhere else -- for example, with VM templating in multiple VMs.
This series adds a warning to ram_block_discard_range() in that problematic case and adds "x-ignore-shared" migration support for virtio-mem, which is pretty straight-forward. The last patch also documents how VM templating interacts with virtio-mem.
v1 -> v2:
- Pick up tags
- "virtio-mem: Support "x-ignore-shared" migration" -> Fix spelling mistake
David Hildenbrand (4):
softmmu/physmem: Warn with ram_block_discard_range() on MAP_PRIVATE
file mapping
virtio-mem: Skip most of virtio_mem_unplug_all() without plugged
memory
migration/ram: Expose ramblock_is_ignored() as
migrate_ram_is_ignored()
virtio-mem: Support "x-ignore-shared" migration
hw/virtio/virtio-mem.c | 67 ++++++++++++++++++++++++++++------------ include/migration/misc.h | 1 + migration/postcopy-ram.c | 2 +- migration/ram.c | 14 ++++----- migration/ram.h | 3 +- softmmu/physmem.c | 18 +++++++++++ 6 files changed, 76 insertions(+), 29 deletions(-)
Signature · 1 line
2.41.0