Skip to content

RFC Switch iotests to pyvenv

John Snow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest6 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6experiment: add mkvenv installpython/scripts/mkvenv.py+40 -00 replies
2/6build, tests: Add qemu in-tree packages to pyvenv at configure time.configure+31 -00 replies
3/6iotests: get rid of '..' in path environment outputtests/qemu-iotests/testenv.py+1 -10 replies
4/6iotests: use the correct python to run linterstests/qemu-iotests/linters.py+1 -10 replies
5/6iotests: use pyvenv/bin/python3 to launch child test processestests/qemu-iotests/testenv.py+14 -10 replies
6/6iotests: don't add qemu.git/python to PYTHONPATHtests/qemu-iotests/testenv.py+0 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH RFC 0/6] Switch iotests to pyvenv

Hi, this is ... a fairly incomplete series about trying to get iotests to run out of the configure-time venv. I'm looking for some feedback, so out to the list it goes.

Primarily, I'm having doubts about these points:

1) I think I need something like "mkvenv install" in the first patch, but mkvenv.py is getting pretty long...

2) Is there a way to optimize the speed for patch #2? Maybe installing this package can be skipped until it's needed, but that means that things like iotest's ./check might get complicated to support that.

3) I cheated quite a bit in patch 4 to use the correct Python to launch iotests, but I'm wondering if there's a nicer way to solve this more *completely*.

John Snow (6):
experiment: add mkvenv install
build, tests: Add qemu in-tree packages to pyvenv at configure time.
iotests: get rid of '..' in path environment output
iotests: use the correct python to run linters
iotests: use pyvenv/bin/python3 to launch child test processes
iotests: don't add qemu.git/python to PYTHONPATH

 configure                     | 31 +++++++++++++++++++++++++++
 python/scripts/mkvenv.py      | 40 +++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/linters.py |  2 +-
 tests/qemu-iotests/testenv.py | 21 ++++++++++++------
 4 files changed, 87 insertions(+), 7 deletions(-)
Signature · 1 line
2.40.1