Skip to content

RFC ui: guest displays multiple connectors suppport and hotplug in

Dongwon Kim qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest9 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9ui/gtk: skip drawing guest scanout when associated VC is invisibleinclude/ui/gtk.h ui/gtk-egl.c ui/gtk-gl-area.c +1 more+26 -10 replies
2/9ui/gtk: set the ui size to 0 when invisibleui/gtk.c+14 -10 replies
3/9ui/gtk: reset visible flag when window is minimizedui/gtk.c+37 -00 replies
4/9ui/gtk: Disable the scanout when a detached tab is closedui/gtk-egl.c ui/gtk-gl-area.c ui/gtk.c+6 -00 replies
5/9ui/gtk: Factor out tab window creation into a separate functionui/gtk.c+39 -320 replies
6/9ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCsinclude/ui/gtk.h qapi/ui.json qemu-options.hx +1 more+263 -2511 replies
7/9ui/gtk: unblock gl if draw submitted already or fence is not yet signaledui/gtk.c+20 -90 replies
8/9ui/gtk: skip drawing if any of ctx/surface/image don't existui/gtk-egl.c+5 -00 replies
9/9ui/gtk: skip refresh/rendering if VC is invisibleui/gtk-egl.c ui/gtk-gl-area.c ui/gtk.c+12 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/9] ui: guest displays multiple connectors suppport and hotplug in

(This series replace two patch series,
[PATCH v2 0/6] ui/gtk: Add a new parameter to assign connectors/monitors (v2)
https://lists.gnu.org/archive/html/qemu-devel/2022-11/msg03098.html and [RFC PATCH 0/3] ui/gtk: no render event when vc is invisible
https://lists.gnu.org/archive/html/qemu-devel/2022-10/msg04926.html)

There is a need (expressed by several customers/users) to assign ownership of one or more physical monitors/connectors to individual Guests such that there is a clear notion of which Guest's contents are being displayed on any given monitor. Given that there is always a Display Server/Compositor running on the Host, monitor ownership can never truly be transferred to Guests. However, the closest we can come to realizing this concept is to request the Host compositor to fullscreen the Guest's windows on individual monitors. This way, it would become possible to have 4 different Guests' windows be displayed on 4 different monitors or a single Guest's windows (or virtual consoles/outputs) be displayed on 4 monitors or any such combination.

This patch series attempts to accomplish this by introducing a new parameter named "connector" to assign the monitors to the GFX VCs associated with a Guest. If the assigned monitor is not connected, then the Guest's window would not be displayed anywhere similar to how a Host compositor would behave when the connectors are not connected. Once the monitor is hotplugged, the Guest's window(s) would be positioned on the assigned monitor.

The first 4 patches (0000~0004) are for some prep work that adds a flag called 'visible' for VC that indicates the visibility of the associated GTK window and making drawing operation skipped for invisible VCs.

0005 and 0006 are actual implementation of monitors/connectors mapping to the guests. 0007 through 0009 are additional code changes for preventing deadlock situation due to asynchronous display hot plug in event when guest scanout is shared as blobs (zero copy display sharing)

Example Usage: -device virtio-gpu-pci,max_outputs=2,blob=true......

               -display gtk,gl=on,connector.0=eDP-1,connector.1=DP-1.....

Dongwon Kim (6):
ui/gtk: skip drawing guest scanout when associated VC is invisible ui/gtk: set the ui size to 0 when invisible
ui/gtk: reset visible flag when window is minimized ui/gtk: unblock gl if draw submitted already or fence is not yet
signaled
ui/gtk: skip drawing if any of ctx/surface/image don't exist ui/gtk: skip refresh/rendering if VC is invisible

Vivek Kasireddy (3):
ui/gtk: Disable the scanout when a detached tab is closed ui/gtk: Factor out tab window creation into a separate function ui/gtk: Add a new parameter to assign connectors/monitors to GFX VCs

 include/ui/gtk.h |   2 +
 qapi/ui.json     |  11 +-
 qemu-options.hx  |   5 +-
 ui/gtk-egl.c     |  20 +++
 ui/gtk-gl-area.c |  14 ++
 ui/gtk.c         | 362 +++++++++++++++++++++++++++++++++++++++++++----
 6 files changed, 384 insertions(+), 30 deletions(-)
Signature · 1 line
2.34.1