Skip to content

net: stmmac: replace boolean fields in plat_stmmacenet_data with flags

Bartosz Golaszewski linux-arm-kernel linux-mediatek linux-sunxi linux-tegra lkml netdev 3 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (main)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest12 patches 2 repliesApplied 12/12
  2. v212 patches 4 repliesSuperseded
  3. v112 patches 3 repliesSuperseded

Changes in v3 from the cover letter

- fix build on intel platforms even more
- collect review tags from Andrew

Patches in v3 All 12 applied

#Subject and filesSizeRepliesApplied
1/12net: stmmac: replace the has_integrated_pcs field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c include/linux/stmmac.h+7 -30 repliesApplied
2/12net: stmmac: replace the sph_disable field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +1 more+5 -40 repliesApplied
3/12net: stmmac: replace the use_phy_wol field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-intel.c drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +1 more+7 -40 repliesApplied
4/12net: stmmac: replace the has_sun8i field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c include/linux/stmmac.h+4 -40 repliesApplied
5/12net: stmmac: replace the tso_en field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c drivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c +5 more+13 -110 repliesApplied
6/12net: stmmac: replace the serdes_up_after_phy_linkup field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c include/linux/stmmac.h+8 -50 repliesApplied
7/12net: stmmac: replace the vlan_fail_q_en field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-intel.c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c include/linux/stmmac.h+4 -30 repliesApplied
8/12net: stmmac: replace the multi_msi_en field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-intel.c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c include/linux/stmmac.h+7 -60 repliesApplied
9/12net: stmmac: replace the ext_snapshot_en field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-intel.c drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c drivers/net/ethernet/stmicro/stmmac/stmmac_ptp.c +1 more+7 -40 repliesApplied
10/12net: stmmac: replace the int_snapshot_en field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-intel.c drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c include/linux/stmmac.h+7 -70 repliesApplied
11/12net: stmmac: replace the rx_clk_runs_in_lpi field with a flagdrivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c drivers/net/ethernet/stmicro/stmmac/stmmac_main.c include/linux/stmmac.h+4 -30 repliesApplied
12/12net: stmmac: replace the en_tx_lpi_clockgating field with a flagdrivers/net/ethernet/stmicro/stmmac/stmmac_main.c drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c include/linux/stmmac.h+4 -40 repliesApplied

Reviews trailers per patch

All 12 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrew HalaneySimon Horman
SeriesR-b
1/12R-b
2/12R-b
3/12R-b
4/12R-b
5/12R-b
6/12R-b
7/12R-b
8/12R-b
9/12R-b
10/12R-b
11/12R-b
12/12R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH net-next v3 00/12] net: stmmac: replace boolean fields in plat_stmmacenet_data with flags

From: Bartosz Golaszewski <[email protected]>

As suggested by Jose Abreu: let's drop all 12 boolean fields in plat_stmmacenet_data and replace them with a common bitfield.

v2 -> v3:
- fix build on intel platforms even more
- collect review tags from Andrew

v1 -> v2:
- fix build on intel platforms

Bartosz Golaszewski (12):
net: stmmac: replace the has_integrated_pcs field with a flag
net: stmmac: replace the sph_disable field with a flag
net: stmmac: replace the use_phy_wol field with a flag
net: stmmac: replace the has_sun8i field with a flag
net: stmmac: replace the tso_en field with a flag
net: stmmac: replace the serdes_up_after_phy_linkup field with a flag
net: stmmac: replace the vlan_fail_q_en field with a flag
net: stmmac: replace the multi_msi_en field with a flag
net: stmmac: replace the ext_snapshot_en field with a flag
net: stmmac: replace the int_snapshot_en field with a flag
net: stmmac: replace the rx_clk_runs_in_lpi field with a flag
net: stmmac: replace the en_tx_lpi_clockgating field with a flag

 .../stmicro/stmmac/dwmac-dwc-qos-eth.c        |  4 +-
 .../net/ethernet/stmicro/stmmac/dwmac-intel.c | 23 +++++------
 .../ethernet/stmicro/stmmac/dwmac-mediatek.c  |  5 ++-
 .../stmicro/stmmac/dwmac-qcom-ethqos.c        |  8 ++--
 .../net/ethernet/stmicro/stmmac/dwmac-sun8i.c |  2 +-
 .../net/ethernet/stmicro/stmmac/dwmac-tegra.c |  4 +-
 .../ethernet/stmicro/stmmac/stmmac_hwtstamp.c |  4 +-
 .../net/ethernet/stmicro/stmmac/stmmac_main.c | 40 +++++++++++--------
 .../net/ethernet/stmicro/stmmac/stmmac_pci.c  |  2 +-
 .../ethernet/stmicro/stmmac/stmmac_platform.c | 10 +++--
 .../net/ethernet/stmicro/stmmac/stmmac_ptp.c  |  5 ++-
 include/linux/stmmac.h                        | 26 ++++++------
 12 files changed, 76 insertions(+), 57 deletions(-)
Signature · 1 line
2.39.2