Skip to content

Add support to print sub-block registers in dpu hw catalog

Ryan McCann dri-devel linux-arm-msm lkml 5 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected] change-id 20230622-devcoredump_patch-df7e8f6fd632

Versions newest first

  1. v5 Latest6 patches 6 repliesApplied
  2. v46 patches 7 repliesSuperseded
  3. v36 patches 0 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v25 patches10 repliesSuperseded
v16 patches16 repliesSuperseded

Changes in v5 from the cover letter

- Fixed indentation in refactor main block printing patch
- Fixed formatting issues to satisfy checkpatch
- Instead of passing 0 for DSC block, used actual length thanks to https://patchwork.freedesktop.org/series/119776/
- Link to v4: https://lore.kernel.org/r/[email protected]

Patches in v5 Applied

#Subject and filesSizeRepliesApplied
1/6drm/msm: Update dev core dump to not print backwardsdrivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c+1 -10 replies
2/6drm/msm/dpu: Drop unused num argument from relevant macrosdrivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c+10 -100 replies
3/6drm/msm/dpu: Define names for unnamed sblksdrivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c+10 -100 replies
4/6drm/msm/dpu: Remove redundant prefix/suffix in name of sub-blocksdrivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c+25 -250 replies
5/6drm/msm/dpu: Refactor printing of main blocks in device core dumpdrivers/gpu/drm/msm/disp/dpu1/dpu_kms.c+8 -82 replies
6/6drm/msm/dpu: Update dev core dump to dump registers of sub-blocksdrivers/gpu/drm/msm/disp/dpu1/dpu_kms.c+54 -122 replies

Reviews trailers per patch

All 6 patches have a Reviewed-by or Acked-by.

PatchAbhinav KumarDmitry Baryshkov
1/6R-b R-b
2/6R-b R-b
3/6R-b R-b
4/6R-b R-b
5/6R-b R-b
6/6R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [PATCH v5 0/6] Add support to print sub-block registers in dpu hw catalog

The purpose of this patch series is to add support to print the registers of sub-blocks in the DPU hardware catalog and fix the order in which all hardware blocks are dumped for a device core dump. This involves:

1. Changing data structure from stack to queue to fix the printing order of the device core dump.

2. Removing redundant suffix of sub-block names.

3. Removing redundant prefix of sub-block names.

4. Eliminating unused variable from relevant macros.

5. Defining names for sub-blocks that have not yet been defined.

6. Implementing wrapper function that prints the registers of sub-blocks when there is a need.

Sample Output of the sspp_0 block and its sub-blocks for devcore dump:
======sspp_0======
...registers
...
====sspp_0_scaler====
...
...
====sspp_0_csc====
...
...
====next_block====
...

This series depends on https://patchwork.freedesktop.org/series/119776/.

---
Changes in v5:
- Fixed indentation in refactor main block printing patch
- Fixed formatting issues to satisfy checkpatch
- Instead of passing 0 for DSC block, used actual length thanks to https://patchwork.freedesktop.org/series/119776/
- Link to v4: https://lore.kernel.org/r/[email protected]

Changes in v4:
- Added review tags
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Split sub-block changes and main block changes into two commits
- Corrected typo in comment located in DSC for loop block
- Eliminated variables mmio and base
- Dropped unnecessary "%s"
- Link to v2: https://lore.kernel.org/r/[email protected]

Changes in v2:
- Changed spelling "sub block" to "sub-block" or "sblk".
- Capitalized DPU.
- Eliminated multiplexer/wrapper function. Inlined instead.
- Changed if statements from feature checks to length checks.
- Squashed prefix and suffix patch into one.
- Link to v1: https://lore.kernel.org/r/[email protected]

---
Ryan McCann (6):
drm/msm: Update dev core dump to not print backwards drm/msm/dpu: Drop unused num argument from relevant macros drm/msm/dpu: Define names for unnamed sblks drm/msm/dpu: Remove redundant prefix/suffix in name of sub-blocks drm/msm/dpu: Refactor printing of main blocks in device core dump drm/msm/dpu: Update dev core dump to dump registers of sub-blocks

 drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c    | 90 +++++++++++------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c           | 74 +++++++++++++++----
 drivers/gpu/drm/msm/disp/msm_disp_snapshot_util.c |  2 +-
 3 files changed, 104 insertions(+), 62 deletions(-)

---
base-commit: a92b5625851098af521cd92e4c518429b661c8f4
change-id: 20230622-devcoredump_patch-df7e8f6fd632

Best regards,

Signature · 1 line
Ryan McCann <[email protected]>