Skip to content

rockchip: rk3588: add support for DFU in SPL

Eugen Hristev u-boot 2 versions – NAK

Status from this message: NAK

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest10 patches 12 repliesNAK
  2. v110 patches 2 repliesSuperseded

Changes in v2 from the cover letter

- rebased on latest upstream which caused a change in the config patch.

Patches in v2

#Subject and filesSizeRepliesApplied
1/10rockchip: allow env defines for SPL buildinclude/configs/rockchip-common.h+0 -41 reply
2/10usb: dwc3: core: improve reset sequencedrivers/usb/dwc3/core.c+19 -121 reply
3/10usb: dwc3: gadget: Don't send unintended link state changedrivers/usb/dwc3/gadget.c drivers/usb/dwc3/gadget.h+21 -91 reply
4/10usb: dwc3: core: Only handle soft-reset in DCTLdrivers/usb/dwc3/core.c+2 -11 reply
5/10usb: dwc3: Increase DWC3 controller halt timeoutdrivers/usb/dwc3/gadget.c+2 -21 reply
6/10ARM: dts: rockchip: rk3588-rock-5b-u-boot: add bootph-all to gadget nodesarch/arm/dts/rk3588-rock-5b-u-boot.dtsi+6 -02 replies
7/10ARM: mach-rockchip: spl-boot-order: add possibility to DFUarch/arm/mach-rockchip/spl-boot-order.c+3 -01 reply
8/10ARM: mach-rockchip: rk3588: add gadget device to the boot orderarch/arm/mach-rockchip/rk3588/rk3588.c+1 -00 replies
9/10rockchip: rk3588: prepare env for DFUinclude/configs/rk3588_common.h+8 -10 replies
10/10configs: rockchip: rock5b-rk3588: enable DFU and related configsconfigs/rock5b-rk3588_defconfig+15 -31 reply

Reviews trailers per patch

3 of 10 patches have a Reviewed-by or Acked-by.

PatchKever Yang
1/10R-b
2/10
3/10
4/10
5/10
6/10
7/10R-b
8/10
9/10
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 00/10] rockchip: rk3588: add support for DFU in SPL

This series adds support for DFU in SPL for rockchip rk3588 on rock5b board.

Namely, when SPL is loaded via rockusb (thus via USB), having the same-as-spl boot order item, after having detected that it was loaded from USB, it will lookup the gadget USB node in DT and boot via DFU.

Some changes were required namely:
- DFU needs environment, hence adding environment variables into DFU
- added bootph-all to nodes such that they are available in SPL
- insert gadget into boot order

I had to port one patch for DWC3 from Linux, and include in this series the patches that are floating from Venkatesh that fixup the DWC3
(https://marc.info/?l=u-boot&m=168351919807081&w=2 )

I know that Marek NAKed them and I am fine with it, I am not trying to sneak in any patches, they are not to be merged, also this patch usb: dwc3: Increase DWC3 controller halt timeout is in the same bucket so Marek you can NAK this one as well, no problem, I am just sending out all the series so maybe the rockchip part for the gadget can be picked up and if people want to use the DFU SPL gadget can also manually pick the DWC3 patches. The branch with all the patches is available here :

https://gitlab.collabora.com/hardware-enablement/rockchip-3588/u-boot

Thanks!

Changes in v2:
- rebased on latest upstream which caused a change in the config patch.

Eugen Hristev (7):
rockchip: allow env defines for SPL build
usb: dwc3: Increase DWC3 controller halt timeout
ARM: dts: rockchip: rk3588-rock-5b-u-boot: add bootph-all to gadget
nodes
ARM: mach-rockchip: spl-boot-order: add possibility to DFU
ARM: mach-rockchip: rk3588: add gadget device to the boot order
rockchip: rk3588: prepare env for DFU
configs: rockchip: rock5b-rk3588: enable DFU and related configs

Venkatesh Yadav Abbarapu (3):
usb: dwc3: core: improve reset sequence
usb: dwc3: gadget: Don't send unintended link state change
usb: dwc3: core: Only handle soft-reset in DCTL

 arch/arm/dts/rk3588-rock-5b-u-boot.dtsi |  6 +++++
 arch/arm/mach-rockchip/rk3588/rk3588.c  |  1 +
 arch/arm/mach-rockchip/spl-boot-order.c |  3 +++
 configs/rock5b-rk3588_defconfig         | 18 +++++++++++---
 drivers/usb/dwc3/core.c                 | 32 +++++++++++++++----------
 drivers/usb/dwc3/gadget.c               | 20 +++++++---------
 drivers/usb/dwc3/gadget.h               | 14 +++++++++++
 include/configs/rk3588_common.h         |  9 ++++++-
 include/configs/rockchip-common.h       |  4 ----
 9 files changed, 76 insertions(+), 31 deletions(-)
Signature · 1 line
2.34.1