Skip to content

Some fixes for select_usb_power_delivery

Kyle Tso linux-usb lkml stable 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 7 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3usb: typec: Set port->pd before adding device for typec_portdrivers/usb/typec/class.c+3 -11 reply
2/3usb: typec: Iterate pds array when showing the pd listdrivers/usb/typec/class.c+5 -61 reply
3/3usb: typec: Use sysfs_emit_at when concatenating the stringdrivers/usb/typec/class.c+2 -21 reply

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchHeikki Krogerus
1/3A-b
2/3A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] Some fixes for select_usb_power_delivery

Update v2

- Add "Cc: [email protected]" to each patch

== original cover letter ==

Hi, here are some fixes about the attribute "select_usb_power_delivery" in typec/class.c

===

usb: typec: Set port->pd before adding device for typec_port

This one is about the visibility of the attribute. port->pd should be set before device_add otherwise the visibility will be false because port->pd is NULL.

===

usb: typec: Iterate pds array when showing the pd list

This patch fixes a problem about the incorrect fetching of the pointers to each usb_power_delivery handle.

===

usb: typec: Use sysfs_emit_at when concatenating the string

This patch changes the use of the API from sysfs_emit to sysfs_emit_at because the buffer address is not aligned to PAGE_SIZE.

===

Kyle Tso (3):
usb: typec: Set port->pd before adding device for typec_port
usb: typec: Iterate pds array when showing the pd list
usb: typec: Use sysfs_emit_at when concatenating the string

 drivers/usb/typec/class.c | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)
Signature · 1 line
2.41.0.162.gfafddb0af9-goog