regmap: Drop never (properly) worked 64-bit support
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | regmap: Revert "add 64-bit mode support" and Co.drivers/ | +0 | 0 replies | |
| 2/3 | regmap: cache: Revert "Add 64-bit mode support"drivers/ | +0 | 0 replies | |
| 3/3 | regmap: mmio: Remove unused 64-bit support codedrivers/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH v1 0/3] regmap: Drop never (properly) worked 64-bit support
regmap API internally operates on unsigned int values for the register offsets and data. The commit back in 2015 that introduces 64-bit excerpts in the code made a false impression that it works. Not really.
Consider two things:
1/ register offset
2/ data
For the first one is very rarely we need (except probably an MMIO case) it. Even though, it won't work due to 32-bit limitations of the base offset. Considering, let's say, 4 bytes stride the current implementation may cover 36-bit of address space _only_. And 37-bit for the 8 bytes stride.
For the second one it's obviously that we want _all_ bits to be covered in the data (otherwise what's the point?) and unsigned int gives us only 32-bits.
With all this, revert all 64-bit excerpts from regmap API to avoid false impressions and new code that never works.
Note, there are no users with such sizes in the kernel.
Andy Shevchenko (3):
regmap: Revert "add 64-bit mode support" and Co.
regmap: cache: Revert "Add 64-bit mode support"
regmap: mmio: Remove unused 64-bit support code
drivers/base/regmap/regcache.c | 15 ---- drivers/base/regmap/regmap-mmio.c | 24 ------ drivers/base/regmap/regmap.c | 122 ------------------------------ 3 files changed, 161 deletions(-)
Signature · 1 line
2.40.0.1.gaa8946217a0b