Skip to content

CIFS DFS fixes for 5.4

Rishabh Bhatnagar linux-cifs lkml stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5cifs: Clean up DFS referral cachefs/cifs/dfs_cache.c+279 -2860 replies
2/5cifs: Get rid of kstrdup_const()'d pathsfs/cifs/dfs_cache.c+3 -32 replies
3/5cifs: Introduce helpers for finding TCP connectionfs/cifs/dfs_cache.c+31 -133 replies
4/5cifs: Merge is_path_valid() into get_normalized_path()fs/cifs/dfs_cache.c+4 -170 replies
5/5cifs: Fix potential deadlock when updating vol in cifs_reconnect()fs/cifs/dfs_cache.c+77 -320 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchAurelien Aptel
1/5R-b
2/5R-b
3/5R-b
4/5R-b
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 5.4 0/5] CIFS DFS fixes for 5.4

We are seeing deadlock in cifs code while updating volume in cifs_reconnect. There are few fixes available in stable trees already. This series backports some patches back to 5.4 stable.

 __schedule+0x268/0x6e0
 schedule+0x2f/0xa0
 schedule_preempt_disabled+0xa/0x10
 __mutex_lock.isra.7+0x20b/0x470
 ? dfs_cache_update_vol+0x45/0x2a0 [cifs]
 dfs_cache_update_vol+0x45/0x2a0 [cifs]
 cifs_reconnect+0x6f2/0xef0 [cifs]
 cifs_handle_standard+0x18d/0x1b0 [cifs]
 cifs_demultiplex_thread+0xa5c/0xc90 [cifs]
 ? cifs_handle_standard+0x1b0/0x1b0 [cifs]

Paulo Alcantara (SUSE) (5):
cifs: Clean up DFS referral cache
cifs: Get rid of kstrdup_const()'d paths
cifs: Introduce helpers for finding TCP connection
cifs: Merge is_path_valid() into get_normalized_path()
cifs: Fix potential deadlock when updating vol in cifs_reconnect()

 fs/cifs/dfs_cache.c | 701 +++++++++++++++++++++++---------------------
 1 file changed, 372 insertions(+), 329 deletions(-)
Signature · 1 line
2.40.1