virtio-net: avoid conflicts between XDP and GUEST_CSUM
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest2 patches 10 repliesIn review
- v32 patches 4 repliesSuperseded
- v23 patches 7 repliesSuperseded
Changes in v4 from the cover letter
- Rewrite some comments for patch [1/2].
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | virtio-net: support coexistence of XDP and GUEST_CSUMdrivers/ | +69 | 10 replies | |
| 2/2 | virtio-net: remove GUEST_CSUM check for XDPdrivers/ | +1 | 0 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Xuan Zhuo |
|---|---|
| 1/2 | R-b |
| 2/2 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next v4 0/2] virtio-net: avoid conflicts between XDP and GUEST_CSUM
virtio-net needs to clear the VIRTIO_NET_F_GUEST_CSUM feature when loading XDP. The main reason for doing this is that received packets marked with VIRTIO_NET_HDR_F_NEEDS_CSUM are not compatible with XDP programs, that is, we cannot guarantee that the csum_{start, offset} fields are correct after XDP processing.
There is also an existing problem, in the same host vm-vm (eg [vm]<->[ovs vhost-user]<->[vm]) scenario, loading XDP will cause packet loss.
To solve the above problems, we have discussed in the [1] proposal, and now try to solve it through the method of reprobing fields suggested by Jason.
[1] https://lists.oasis-open.org/archives/virtio-dev/202305/msg00318.html
---v3->v4:
- Rewrite some comments for patch [1/2].
v2->v3:
- Use skb_checksum_setup() instead of virtnet_flow_dissect_udp_tcp(). @Jason Wang
v1->v2:
- Squash v1's patch [1/4] and patch [2/4] into v2's patch [1/3]. @Michael S. Tsirkin
- Some minor modifications.
Heng Qi (2):
virtio-net: support coexistence of XDP and GUEST_CSUM
virtio-net: remove GUEST_CSUM check for XDP
drivers/net/virtio_net.c | 86 ++++++++++++++++++++++++++++++++-------- 1 file changed, 70 insertions(+), 16 deletions(-)
Signature · 1 line
2.19.1.6.gb485710b