Skip to content

vfio/migration: Make VFIO migration non-experimental

Avihai Horon qemu-devel 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 7 repliesIn review
  2. v13 patches 18 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2vfio/migration: Reset bytes_transferred properlyhw/vfio/migration.c include/hw/vfio/vfio-common.h migration/migration.c +3 more+24 -31 reply
2/2vfio/migration: Make VFIO migration non-experimentalhw/vfio/common.c hw/vfio/migration.c hw/vfio/pci.c +2 more+73 -345 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchCédric Le GoaterJoao MartinsAlex Williamson
SeriesR-b
1/2R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/2] vfio/migration: Make VFIO migration non-experimental

Hello,

The major parts of VFIO migration are supported today in QEMU. This includes basic VFIO migration, device dirty page tracking and precopy support. Thus, at this point in time, it seems appropriate to make VFIO migration non-experimental.

This short series (which is based on the precopy series [1]) does that and also adds a few improvements:
- Patch #1 resets bytes_transferred counter properly.
- Patch #2 cleans up the VFIO migration realize flow and makes VFIO migration non-experimental.

Note that Zhenzhong's series [2] fixes additional bugs and further cleans the VFIO migration realize flow.

Changes from v1 [3]:
* Dropped patch #1 as it's an optimization. (Cedric)
* Added Fixes tag to patch #2. (Cedric)
* Made VFIO device realization fail if migration is not supported and enable_migration is ON. (Cedric)
* Kept the error message of errno == ENOTTY case as it was in vfio_migration_query_flags(). (Cedric)
* Added a warn when enable_migration is ON and device dirty tracking is not supported. (Alex)
* Renamed trace_vfio_migration_probe() to
* trace_vfio_migration_realize().

Thanks.

[1]
https://lore.kernel.org/qemu-devel/[email protected]/

[2]
https://lore.kernel.org/qemu-devel/[email protected]/

[3]
https://lore.kernel.org/qemu-devel/[email protected]/

Avihai Horon (2):
vfio/migration: Reset bytes_transferred properly vfio/migration: Make VFIO migration non-experimental

 include/hw/vfio/vfio-common.h |  7 +--
 migration/migration.h         |  1 +
 hw/vfio/common.c              | 16 ++++++-
 hw/vfio/migration.c           | 85 ++++++++++++++++++++++++-----------
 hw/vfio/pci.c                 |  4 +-
 migration/migration.c         |  1 +
 migration/savevm.c            |  1 +
 migration/target.c            | 17 ++++++-
 hw/vfio/trace-events          |  2 +-
 9 files changed, 97 insertions(+), 37 deletions(-)
Signature · 1 line
2.26.3