Skip to content

parse-events clean up

Ian Rogers bpf kernel-janitors linux-perf-users lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest13 patches 21 repliesIn review
  2. v113 patches 0 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13perf parse-events: Remove unused PE_PMU_EVENT_FAKE tokentools/perf/util/parse-events.y+2 -4011 replies
2/13perf parse-events: Remove unused PE_KERNEL_PMU_EVENT tokentools/perf/util/parse-events.y+0 -270 replies
3/13perf parse-events: Remove two unused tokenstools/perf/util/parse-events.y+1 -10 replies
4/13perf parse-events: Add more comments to parse_events_statetools/perf/util/parse-events.h+8 -00 replies
5/13perf parse-events: Avoid regrouped warning for wild card eventstools/perf/util/parse-events.c+1 -00 replies
6/13perf parse-event: Add memory allocation test for name termstools/perf/util/parse-events.c tools/perf/util/parse-events.y+5 -20 replies
7/13perf parse-events: Separate YYABORT and YYNOMEM casestools/perf/util/parse-events.y+26 -190 replies
8/13perf parse-events: Move instances of YYABORT to YYNOMEMtools/perf/util/parse-events.y+40 -180 replies
9/13perf parse-events: Separate ENOMEM memory handlingtools/perf/util/parse-events.y+82 -520 replies
10/13perf parse-events: Additional error reportingtools/perf/util/parse-events.y+19 -60 replies
11/13perf parse-events: Populate error column for BPF/tracepoint eventstools/perf/tests/bpf.c tools/perf/util/parse-events.c tools/perf/util/parse-events.h +1 more+57 -390 replies
12/13perf parse-events: Improve location for add pmutools/perf/util/parse-events.c tools/perf/util/parse-events.h tools/perf/util/parse-events.y+13 -110 replies
13/13perf parse-events: Remove ABORT_ONtools/perf/util/parse-events.y+14 -810 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/13] parse-events clean up

Remove some tokens the lexer never produces. Ensure abort paths set an error. Previously scanning all PMUs meant bad events could fail with an invalid token, detect this at the point parsing for a PMU fails and add error strings. Try to be consistent in using YYNOMEM for memory failures and YYABORT for bad input.

v2. Fix build error when building without libtraceevent.

Ian Rogers (13):
perf parse-events: Remove unused PE_PMU_EVENT_FAKE token perf parse-events: Remove unused PE_KERNEL_PMU_EVENT token perf parse-events: Remove two unused tokens
perf parse-events: Add more comments to parse_events_state perf parse-events: Avoid regrouped warning for wild card events perf parse-event: Add memory allocation test for name terms perf parse-events: Separate YYABORT and YYNOMEM cases perf parse-events: Move instances of YYABORT to YYNOMEM perf parse-events: Separate ENOMEM memory handling
perf parse-events: Additional error reporting
perf parse-events: Populate error column for BPF/tracepoint events perf parse-events: Improve location for add pmu
perf parse-events: Remove ABORT_ON

 tools/perf/tests/bpf.c         |   2 +-
 tools/perf/util/parse-events.c |  98 +++++----
 tools/perf/util/parse-events.h |  20 +-
 tools/perf/util/parse-events.y | 351 +++++++++++++++++----------------
 4 files changed, 258 insertions(+), 213 deletions(-)
Signature · 1 line
2.41.0.162.gfafddb0af9-goog