Skip to content

perf lock contention: Add CSV style output support (v2)

Namhyung Kim linux-perf-users lkml 1 version Applied

Status from this message: Applied to perf-tools-next, thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 6 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4perf lock: Remove stale commentstools/perf/builtin-lock.c+0 -21 reply
2/4perf lock contention: Add -x option for CSV style outputtools/perf/Documentation/perf-lock.txt tools/perf/builtin-lock.c+241 -672 replies
3/4perf lock contention: Add --output optiontools/perf/Documentation/perf-lock.txt tools/perf/builtin-lock.c+85 -581 reply
4/4perf test: Test perf lock contention CSV outputtools/perf/tests/shell/lock_contention.sh+36 -01 reply

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchIan Rogers
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCHSET 0/4] perf lock contention: Add CSV style output support (v2)

Hello,

This is v2 of perf lock contention CSV output change.
I've added --output option and a test case according to Ian's feedback.

Sometimes we want to process the output by external programs. Let's add the -x option to specify the field separator like perf stat.

  $ sudo ./perf lock con -ab -x, sleep 1
  # output: contended, total wait, max wait, avg wait, type, caller
  19, 194232, 21415, 10222, spinlock, process_one_work+0x1f0
  15, 162748, 23843, 10849, rwsem:R, do_user_addr_fault+0x40e
  4, 86740, 23415, 21685, rwlock:R, ep_poll_callback+0x2d
  1, 84281, 84281, 84281, mutex, iwl_mvm_async_handlers_wk+0x135
  8, 67608, 27404, 8451, spinlock, __queue_work+0x174
  3, 58616, 31125, 19538, rwsem:W, do_mprotect_pkey+0xff
  3, 52953, 21172, 17651, rwlock:W, do_epoll_wait+0x248
  2, 30324, 19704, 15162, rwsem:R, do_madvise+0x3ad
  1, 24619, 24619, 24619, spinlock, rcu_core+0xd4

The first line is a comment that shows the output format. Each line is separated by the given string ("," in this case). The time is printed in nsec without the unit so that it can be parsed easily.

The code is available at 'perf/lock-con-csv-v2' branch in

git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git

Thanks,
Namhyung

Namhyung Kim (4):
perf lock: Remove stale comments
perf lock contention: Add -x option for CSV style output perf lock contention: Add --output option
perf test: Test perf lock contention CSV output

 tools/perf/Documentation/perf-lock.txt    |   5 +
 tools/perf/builtin-lock.c                 | 383 ++++++++++++++++------
 tools/perf/tests/shell/lock_contention.sh |  36 ++
 3 files changed, 328 insertions(+), 96 deletions(-)
Signature · 1 line
2.41.0.255.g8b1d071c50-goog