migration: Better error handling in return path thread
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest7 patches 15 repliesIn review
- v17 patches 4 repliesSuperseded
Changes in v2 from the cover letter
- Patch "migration: Provide explicit error message for file shutdowns"
- Touched up qapi doc [Fabiano]
- Added Bugzilla link to commit which I didn't even notice that I was fixing a bug.. but rightfully pointed out by Laszlo.
- Moved it to the 1st patch because it fixes a bug, please consider review and merge it earlier.
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | migration: Display error in query-migrate irrelevant of statusmigration/ qapi/ | +7 | 0 replies | |
| 2/7 | migration: Let migrate_set_error() take ownershipmigration/ migration/ migration/ +3 more | +21 | 1 reply | |
| 3/7 | migration: Introduce migrate_has_error()migration/ migration/ | +16 | 1 reply | |
| 4/7 | migration: Refactor error handling in source return pathmigration/ migration/ migration/ +2 more | +82 | 0 replies | |
| 5/7 | migration: Deliver return path file error to migrate state toomigration/ | +7 | 0 replies | |
| 6/7 | qemufile: Always return a verbose errormigration/ | +12 | 3 replies | |
| 7/7 | migration: Provide explicit error message for file shutdownsmigration/ | +4 | 7 replies |
Reviews trailers per patch
6 of 7 patches have a Reviewed-by or Acked-by.
| Patch | Fabiano Rosas |
|---|---|
| 1/7 | R-b |
| 2/7 | R-b |
| 3/7 | R-b |
| 4/7 | R-b |
| 5/7 | R-b |
| 6/7 | R-b |
| 7/7 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v2 0/7] migration: Better error handling in return path thread
v2:
- Patch "migration: Provide explicit error message for file shutdowns"
- Touched up qapi doc [Fabiano]
- Added Bugzilla link to commit which I didn't even notice that I was fixing a bug.. but rightfully pointed out by Laszlo.
- Moved it to the 1st patch because it fixes a bug, please consider review and merge it earlier.
This is a small series that reworks error handling of postcopy return path threads.
We used to contain a bunch of error_report(), converting them into error_setg() properly and deliver any of those errors to migration generic error reports (via migrate_set_error()). Then these errors can also be observed in query-migrate after postcopy is paused.
Dropped the return-path specific error reporting: mark_source_rp_bad(), because it's a duplication if we can always use migrate_set_error().
Please have a look, thanks.
Peter Xu (7):
migration: Display error in query-migrate irrelevant of status
migration: Let migrate_set_error() take ownership
migration: Introduce migrate_has_error()
migration: Refactor error handling in source return path
migration: Deliver return path file error to migrate state too
qemufile: Always return a verbose error
migration: Provide explicit error message for file shutdowns
qapi/migration.json | 5 +- migration/migration.h | 8 +- migration/ram.h | 5 +- migration/channel.c | 1 - migration/migration.c | 168 +++++++++++++++++++++++---------------- migration/multifd.c | 10 +-- migration/postcopy-ram.c | 1 - migration/qemu-file.c | 20 ++++- migration/ram.c | 42 +++++----- migration/trace-events | 2 +- 10 files changed, 149 insertions(+), 113 deletions(-)
Signature · 1 line
2.41.0